jenkins-bot has submitted this change and it was merged.
Change subject: ReferenceWidget: Rename view to preview
......................................................................
ReferenceWidget: Rename view to preview
This property is a PreviewElement, not a view node.
Change-Id: I6ee7e8a02100b9df101d1597f0d2b84825a781bc
---
M modules/ve.ui.CiteFromIdReferenceWidget.js
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve.ui.CiteFromIdReferenceWidget.js
b/modules/ve.ui.CiteFromIdReferenceWidget.js
index ee6e041..7d4c047 100644
--- a/modules/ve.ui.CiteFromIdReferenceWidget.js
+++ b/modules/ve.ui.CiteFromIdReferenceWidget.js
@@ -64,9 +64,9 @@
documentModel.getHtmlDocument()
);
node = doc.getDocumentNode().getChildren()[ 0 ];
- this.view = new ve.ui.PreviewElement( node );
- if ( this.view.isGenerating() ) {
- this.view.once( 'render', this.renderPromise.resolve );
+ this.preview = new ve.ui.PreviewElement( node );
+ if ( this.preview.isGenerating() ) {
+ this.preview.once( 'render', this.renderPromise.resolve );
} else {
this.renderPromise.resolve();
}
@@ -86,7 +86,7 @@
this.$icon,
title.$element,
this.insertButton.$element,
- this.view.$element
+ this.preview.$element
);
};
@@ -102,7 +102,7 @@
*/
ve.ui.CiteFromIdReferenceWidget.prototype.destroy = function () {
this.renderPromise.reject();
- this.view.destroy();
+ this.preview.destroy();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/248834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ee7e8a02100b9df101d1597f0d2b84825a781bc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
