Ottomata has submitted this change and it was merged.
Change subject: Disable all diamond varnishreqstats collectors
......................................................................
Disable all diamond varnishreqstats collectors
Bug: T83580
Change-Id: Ic445e10ad77cb091510edd1f1aa7e4e6c28abd58
---
M modules/varnish/manifests/monitoring/varnishreqstats.pp
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Ottomata: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/varnish/manifests/monitoring/varnishreqstats.pp
b/modules/varnish/manifests/monitoring/varnishreqstats.pp
index fad253b..2ad1902 100644
--- a/modules/varnish/manifests/monitoring/varnishreqstats.pp
+++ b/modules/varnish/manifests/monitoring/varnishreqstats.pp
@@ -13,10 +13,13 @@
# If $name is text.frontend, this will create graphite keys that look like:
# servers.cp1052.varnish.eqiad.text.frontend.request.client.status.2xx
#
+# NOTE: Diamond collectors using varnishlog and multiprocessing doesn't work.
+# They will all be removed and replaced with a service sending directly
+# to statsd.
define varnish::monitoring::varnishreqstats(
$instance_name = $name,
$metric_path = "varnish.${::site}.${name}.request",
- $ensure = 'present',
+ $ensure = 'absent',
) {
# ${collector_name}Collector will be used as the python diamond collector
class name
# when varnishreqstats-diamond.py.erb is rendered.
--
To view, visit https://gerrit.wikimedia.org/r/248888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic445e10ad77cb091510edd1f1aa7e4e6c28abd58
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
