jenkins-bot has submitted this change and it was merged.
Change subject: Do not hide menu behind page footer
......................................................................
Do not hide menu behind page footer
Because of the way the full-height sidebar
is implemented (with overflow:hidden) the
last post's menu sometimes get hidden
behind the footer.
This adds some space at the bottom to
make sure the menu is fully visible.
Bug: T116077
Change-Id: Ifb08189f273562af6f2d5da4965a11c1e4508fd8
---
M handlebars/compiled/flow_block_topiclist.handlebars.php
M handlebars/flow_load_more.partial.handlebars
M modules/styles/common.less
3 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/handlebars/compiled/flow_block_topiclist.handlebars.php
b/handlebars/compiled/flow_block_topiclist.handlebars.php
index 721e35a..849097e 100644
--- a/handlebars/compiled/flow_block_topiclist.handlebars.php
+++ b/handlebars/compiled/flow_block_topiclist.handlebars.php
@@ -262,6 +262,7 @@
'.$sp.'' : ' <div class="flow-no-more">
'.$sp.' '.LCRun3::ch($cx, 'l10n',
array(array('flow-no-more-fwd'),array()), 'encq').'
'.$sp.' </div>
+'.$sp.' <div class="bottom-spacer"></div>
'.$sp.'').'';},),
'scopes' => array(),
'sp_vars' => array('root' => $in),
diff --git a/handlebars/flow_load_more.partial.handlebars
b/handlebars/flow_load_more.partial.handlebars
index cbb0ab0..edc591a 100644
--- a/handlebars/flow_load_more.partial.handlebars
+++ b/handlebars/flow_load_more.partial.handlebars
@@ -22,4 +22,5 @@
{{!-- TODO: Does this i18n message need to be generalized? --}}
{{l10n "flow-no-more-fwd"}}
</div>
+ <div class="bottom-spacer"></div>
{{/if}}
diff --git a/modules/styles/common.less b/modules/styles/common.less
index 1fd5eae..e1a5f75 100644
--- a/modules/styles/common.less
+++ b/modules/styles/common.less
@@ -91,6 +91,12 @@
line-height: 0;
}
+// This is to make sure there is enough space
+// at the bottom to display the last post's menu.
+.bottom-spacer {
+ height: 50px;
+}
+
@media all and (min-width: @small) {
.flow-topic-meta {
font-size: 1em;
--
To view, visit https://gerrit.wikimedia.org/r/248154
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb08189f273562af6f2d5da4965a11c1e4508fd8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
