Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249104
Change subject: Clear ObjectCache for all other tests, too
......................................................................
Clear ObjectCache for all other tests, too
Change-Id: I9c18a47b9ce26f3a0fb24b9b843f866fc7973d4b
---
M repo/tests/phpunit/includes/EditEntityTest.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/04/249104/1
diff --git a/repo/tests/phpunit/includes/EditEntityTest.php
b/repo/tests/phpunit/includes/EditEntityTest.php
index 9d97a65..5101679 100644
--- a/repo/tests/phpunit/includes/EditEntityTest.php
+++ b/repo/tests/phpunit/includes/EditEntityTest.php
@@ -646,9 +646,6 @@
CACHE_ANYTHING
);
- // make sure we have a fresh cache
- ObjectCache::clear();
-
$user = $this->getUser( 'UserForTestAttemptSaveRateLimit' );
$this->setUserGroups( $user, $groups );
@@ -677,6 +674,9 @@
$this->assertEquals( $expectedOK,
$edit->getStatus()->isOK(), var_export( $edit->getStatus()->getErrorsArray(),
true ) );
$this->assertNotEquals( $expectedOK, $edit->hasError(
EditEntity::RATE_LIMIT ) );
}
+
+ // Make sure nobody else has to work with our cache
+ ObjectCache::clear();
}
public function provideIsTokenOk() {
--
To view, visit https://gerrit.wikimedia.org/r/249104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c18a47b9ce26f3a0fb24b9b843f866fc7973d4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
