jenkins-bot has submitted this change and it was merged.
Change subject: Get rid of CSS transitions on form elements in mediawiki.ui
......................................................................
Get rid of CSS transitions on form elements in mediawiki.ui
They seem to serve no function whatsoever other than to irritate and delay the
loading of the page.
Change-Id: I54c195541713a5bfbc8bd7078499ac49671697c6
---
M resources/src/mediawiki.ui/components/buttons.less
M resources/src/mediawiki.ui/components/checkbox.less
M resources/src/mediawiki.ui/components/inputs.less
M resources/src/mediawiki.ui/components/radio.less
4 files changed, 0 insertions(+), 8 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
Bartosz Dziewoński: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.ui/components/buttons.less
b/resources/src/mediawiki.ui/components/buttons.less
index d66973a..600b771 100644
--- a/resources/src/mediawiki.ui/components/buttons.less
+++ b/resources/src/mediawiki.ui/components/buttons.less
@@ -12,9 +12,6 @@
//
// Styleguide 2.
-@transitionDuration: .1s;
-@transitionFunction: ease-in-out;
-
// Neutral button styling
//
// These are the main actions on the page/workflow. The page should have only
one of progressive, constructive and desctructive buttons, the rest being quiet.
@@ -65,8 +62,6 @@
text-shadow: none;
cursor: default;
}
-
- .transition(background @transitionDuration @transitionFunction, color
@transitionDuration @transitionFunction, box-shadow @transitionDuration
@transitionFunction;);
// Styling for specific button types
// -----------------------------------------
diff --git a/resources/src/mediawiki.ui/components/checkbox.less
b/resources/src/mediawiki.ui/components/checkbox.less
index ac5becb..bd5dd4a 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -72,7 +72,6 @@
// the pseudo before element of the label after the checkbox
now looks like a checkbox
& + label::before {
- .transition( 0.2s cubic-bezier(0.175, 0.885, 0.32,
1.275) );
content: '';
cursor: pointer;
.box-sizing(border-box);
diff --git a/resources/src/mediawiki.ui/components/inputs.less
b/resources/src/mediawiki.ui/components/inputs.less
index 2f76131..62f0e83 100644
--- a/resources/src/mediawiki.ui/components/inputs.less
+++ b/resources/src/mediawiki.ui/components/inputs.less
@@ -39,7 +39,6 @@
font-family: inherit;
font-size: inherit;
line-height: inherit;
- .transition(~"border 0.2s cubic-bezier(0.39, 0.575, 0.565, 1),
box-shadow 0.2s cubic-bezier(0.39, 0.575, 0.565, 1)");
// Placeholder text styling must be set individually for each browser
@winter
&::-webkit-input-placeholder { // webkit
diff --git a/resources/src/mediawiki.ui/components/radio.less
b/resources/src/mediawiki.ui/components/radio.less
index 1928699..52effd6 100644
--- a/resources/src/mediawiki.ui/components/radio.less
+++ b/resources/src/mediawiki.ui/components/radio.less
@@ -63,7 +63,6 @@
// the pseudo before element of the label after the radio now
looks like a radio
& + label::before {
- .transition( 0.2s cubic-bezier(0.175, 0.885, 0.32,
1.275) );
content: '';
cursor: pointer;
.box-sizing(border-box);
--
To view, visit https://gerrit.wikimedia.org/r/249053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54c195541713a5bfbc8bd7078499ac49671697c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
