jenkins-bot has submitted this change and it was merged.
Change subject: AceEditorWidget: Make setters chainable and support invalid flag
......................................................................
AceEditorWidget: Make setters chainable and support invalid flag
Change-Id: I78f395459f526164c0c506beec62a0083817e64b
---
M modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
M modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
2 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
index b11d584..73ce7c0 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
@@ -20,3 +20,7 @@
border-width: 2px;
margin: 0;
}
+
+.ve-ui-mwAceEditorWidget.oo-ui-widget-enabled.oo-ui-flaggedElement-invalid
.ace_editor {
+ border-color: red;
+}
\ No newline at end of file
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
index 234aba3..86797c4 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
@@ -101,6 +101,7 @@
} ).fail( function () {
ve.ui.MWAceEditorWidget.super.prototype.setValue.call( widget,
value );
} );
+ return this;
};
/**
@@ -115,24 +116,28 @@
* Toggle the visibility of line numbers
*
* @param {boolean} visible Visible
+ * @chainable
*/
ve.ui.MWAceEditorWidget.prototype.toggleLineNumbers = function ( visible ) {
var widget = this;
this.loadingPromise.done( function () {
widget.editor.renderer.setOption( 'showLineNumbers', visible );
} );
+ return this;
};
/**
* Set the language mode of the editor (programming language)
*
* @param {string} lang Language
+ * @chainable
*/
ve.ui.MWAceEditorWidget.prototype.setLanguage = function ( lang ) {
var widget = this;
this.loadingPromise.done( function () {
widget.editor.getSession().setMode( 'ace/mode/' + ( require(
'ace/mode/' + lang ) ? lang : 'text' ) );
} );
+ return this;
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/249204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78f395459f526164c0c506beec62a0083817e64b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
