Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249339
Change subject: Use global key for user cache in CentralAuthUser
......................................................................
Use global key for user cache in CentralAuthUser
Depends on I58836a24b9e239f4 in MediaWiki core.
Change-Id: Ia9673a448da81bb3a59ee143b7e1c4adbcb6a971
---
M includes/CentralAuthUser.php
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth
refs/changes/39/249339/1
diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index 99a06ce..a8651d0 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -2882,11 +2882,13 @@
}
/**
- * @param string $wiki
- * @param integer $id
+ * @param string $wikiId
+ * @param integer $userId
*/
- private function clearLocalUserCache( $wiki, $id ) {
+ private function clearLocalUserCache( $wikiId, $userId ) {
// @TODO: this has poor separation of concerns :/
- ObjectCache::getMainWANInstance()->delete( "$wiki:user:id:$id"
);
+ $cache = ObjectCache::getMainWANInstance();
+ $key = $cache->makeGlobalKey( 'user', 'id', $wikiId, $userId );
+ $cache->delete( $key );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/249339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9673a448da81bb3a59ee143b7e1c4adbcb6a971
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
