Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249417
Change subject: Update for breaking change for mixins in OOUI
......................................................................
Update for breaking change for mixins in OOUI
Change-Id: I7ded743a11e1025d49727b892cdda0f0243b029f
---
M modules/ve-graph/widgets/ve.ui.RowWidget.js
M modules/ve-graph/widgets/ve.ui.TableWidget.js
2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Graph
refs/changes/17/249417/1
diff --git a/modules/ve-graph/widgets/ve.ui.RowWidget.js
b/modules/ve-graph/widgets/ve.ui.RowWidget.js
index 0a41360..47dbee5 100644
--- a/modules/ve-graph/widgets/ve.ui.RowWidget.js
+++ b/modules/ve-graph/widgets/ve.ui.RowWidget.js
@@ -6,7 +6,7 @@
*
* @class
* @extends OO.ui.Widget
- * @mixins OO.ui.GroupElement
+ * @mixins OO.ui.mixin.GroupElement
*
* @constructor
* @param {Object} [config] Configuration options
@@ -29,7 +29,7 @@
ve.ui.RowWidget.super.call( this, config );
// Mixin constructor
- OO.ui.GroupElement.call( this, config );
+ OO.ui.mixin.GroupElement.call( this, config );
// Properties
// TODO: The key should be stored in data to leverage getItemFromData
in TableWidget
@@ -96,7 +96,7 @@
/* Inheritance */
OO.inheritClass( ve.ui.RowWidget, OO.ui.Widget );
-OO.mixinClass( ve.ui.RowWidget, OO.ui.GroupElement );
+OO.mixinClass( ve.ui.RowWidget, OO.ui.mixin.GroupElement );
/* Events */
diff --git a/modules/ve-graph/widgets/ve.ui.TableWidget.js
b/modules/ve-graph/widgets/ve.ui.TableWidget.js
index e87e4c3..e2e2dbc 100644
--- a/modules/ve-graph/widgets/ve.ui.TableWidget.js
+++ b/modules/ve-graph/widgets/ve.ui.TableWidget.js
@@ -4,7 +4,7 @@
*
* @class
* @extends OO.ui.Widget
- * @mixins OO.ui.GroupElement
+ * @mixins OO.ui.mixin.GroupElement
*
* @constructor
* @param {string[]} fields The labels for the fields
@@ -26,7 +26,7 @@
ve.ui.TableWidget.super.call( this, config );
// Mixin constructors
- OO.ui.GroupElement.call( this, config );
+ OO.ui.mixin.GroupElement.call( this, config );
// Properties
this.fields = fields;
@@ -118,7 +118,7 @@
/* Inheritance */
OO.inheritClass( ve.ui.TableWidget, OO.ui.Widget );
-OO.mixinClass( ve.ui.TableWidget, OO.ui.GroupElement );
+OO.mixinClass( ve.ui.TableWidget, OO.ui.mixin.GroupElement );
/* Static Properties */
ve.ui.TableWidget.static.patterns = {
@@ -157,7 +157,7 @@
startingIndex = this.items.length;
// Parent function
- OO.ui.GroupElement.prototype.addItems.call( this, items );
+ OO.ui.mixin.GroupElement.prototype.addItems.call( this, items );
for ( i = 0, len = items.length; i < len; i++ ) {
// Assign row index to every new row
@@ -173,7 +173,7 @@
rows = this.getItems();
// Parent function
- OO.ui.GroupElement.prototype.removeItems.call( this, items );
+ OO.ui.mixin.GroupElement.prototype.removeItems.call( this, items );
// Refresh row indexes for every remaining row
for ( i = 0, len = rows.length; i < len; i++ ) {
@@ -224,7 +224,7 @@
ve.ui.TableWidget.prototype.getRowFromKey = function ( key ) {
var i, rows = this.getItems();
- // TODO: Leverage OO.ui.GroupElement.getItemFromData instead of looping
rows
+ // TODO: Leverage OO.ui.mixin.GroupElement#getItemFromData instead of
looping rows
for ( i = 0; i < rows.length; i++ ) {
if ( rows[ i ].getKey() === key ) {
return rows[ i ];
--
To view, visit https://gerrit.wikimedia.org/r/249417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ded743a11e1025d49727b892cdda0f0243b029f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Graph
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
