Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249432
Change subject: Rename notification from 'subscribe-newsletter' to
'newsletter-announce'
......................................................................
Rename notification from 'subscribe-newsletter' to 'newsletter-announce'
This is misleading as what we're doing here is announcing not subscribing.
Also start to use "newsletter-" prefix as this will be nicer when we start
to use other notifications.
Change-Id: I61fa37f061409ac46aeec4ac149bacafbf20afd8
---
M Newsletter.hooks.php
M includes/specials/SpecialNewsletterManage.php
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/32/249432/1
diff --git a/Newsletter.hooks.php b/Newsletter.hooks.php
index 9c86f59..b6f2c9e 100755
--- a/Newsletter.hooks.php
+++ b/Newsletter.hooks.php
@@ -17,8 +17,8 @@
'priority' => 3,
'tooltip' => 'echo-pref-tooltip-newsletter',
);
- // @todo rename event as this is misleading - we're not really
subscribing here
- $notifications['subscribe-newsletter'] = array(
+
+ $notifications['newsletter-announce'] = array(
'primary-link' => array(
'message' =>
'newsletter-notification-link-text-new-issue',
'destination' => 'new-issue'
diff --git a/includes/specials/SpecialNewsletterManage.php
b/includes/specials/SpecialNewsletterManage.php
index 8c46460..d1195e7 100644
--- a/includes/specials/SpecialNewsletterManage.php
+++ b/includes/specials/SpecialNewsletterManage.php
@@ -153,7 +153,7 @@
if ( class_exists( 'EchoEvent' ) ) {
EchoEvent::create(
array(
- 'type' =>
'subscribe-newsletter',
+ 'type' =>
'newsletter-announce',
'extra' => array(
'newsletter' =>
$newsletter->getName(),
'newsletterId'
=> $newsletter->getId(),
--
To view, visit https://gerrit.wikimedia.org/r/249432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61fa37f061409ac46aeec4ac149bacafbf20afd8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
