Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249435
Change subject: Rename DataUpdate classes to DataUpdater with an r
......................................................................
Rename DataUpdate classes to DataUpdater with an r
These interfaces and classes are active components. They actually do
the updates to the parser output.
Change-Id: If290acdddfec3f0ce5efbc373384ab9886bbb158
---
M repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
M repo/includes/ParserOutput/EntityParserOutputGenerator.php
M repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
R repo/includes/ParserOutput/ExternalLinksDataUpdater.php
R repo/includes/ParserOutput/GeoDataDataUpdater.php
R repo/includes/ParserOutput/ImageLinksDataUpdater.php
R repo/includes/ParserOutput/PageImagesDataUpdater.php
R repo/includes/ParserOutput/ParserOutputDataUpdater.php
R repo/includes/ParserOutput/ReferencedEntitiesDataUpdater.php
R repo/includes/ParserOutput/SiteLinkDataUpdater.php
R repo/includes/ParserOutput/StatementDataUpdater.php
M repo/tests/phpunit/includes/ParserOutput/EntityParserOutputDataUpdaterTest.php
M repo/tests/phpunit/includes/ParserOutput/EntityParserOutputGeneratorTest.php
R repo/tests/phpunit/includes/ParserOutput/ExternalLinksDataUpdaterTest.php
R repo/tests/phpunit/includes/ParserOutput/GeoDataDataUpdaterTest.php
R repo/tests/phpunit/includes/ParserOutput/ImageLinksDataUpdaterTest.php
R repo/tests/phpunit/includes/ParserOutput/PageImagesDataUpdaterTest.php
R repo/tests/phpunit/includes/ParserOutput/ReferencedEntitiesDataUpdaterTest.php
18 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/35/249435/1
diff --git a/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
b/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
index 3cb694c..be2ef6f 100644
--- a/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
+++ b/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
@@ -25,35 +25,35 @@
private $parserOutput;
/**
- * @var ParserOutputDataUpdate[]
+ * @var ParserOutputDataUpdater[]
*/
private $dataUpdates;
/**
- * @var StatementDataUpdate[]
+ * @var StatementDataUpdater[]
*/
private $statementDataUpdates = array();
/**
- * @var SiteLinkDataUpdate[]
+ * @var SiteLinkDataUpdater[]
*/
private $siteLinkDataUpdates = array();
/**
* @param ParserOutput $parserOutput
- * @param ParserOutputDataUpdate[] $dataUpdates
+ * @param ParserOutputDataUpdater[] $dataUpdates
*
* @throws InvalidArgumentException
*/
public function __construct( ParserOutput $parserOutput, array
$dataUpdates ) {
foreach ( $dataUpdates as $dataUpdate ) {
- if ( $dataUpdate instanceof StatementDataUpdate ) {
+ if ( $dataUpdate instanceof StatementDataUpdater ) {
$this->statementDataUpdates[] = $dataUpdate;
- } elseif ( $dataUpdate instanceof SiteLinkDataUpdate ) {
+ } elseif ( $dataUpdate instanceof SiteLinkDataUpdater )
{
$this->siteLinkDataUpdates[] = $dataUpdate;
} else {
throw new InvalidArgumentException( 'Each
$dataUpdates element must be a '
- . 'StatementDataUpdate,
SiteLinkDataUpdate or both' );
+ . 'StatementDataUpdater,
SiteLinkDataUpdater or both' );
}
}
diff --git a/repo/includes/ParserOutput/EntityParserOutputGenerator.php
b/repo/includes/ParserOutput/EntityParserOutputGenerator.php
index e26d06a..d23b7b1 100644
--- a/repo/includes/ParserOutput/EntityParserOutputGenerator.php
+++ b/repo/includes/ParserOutput/EntityParserOutputGenerator.php
@@ -76,7 +76,7 @@
private $entityDataFormatProvider;
/**
- * @var ParserOutputDataUpdate[]
+ * @var ParserOutputDataUpdater[]
*/
private $dataUpdates;
@@ -193,7 +193,7 @@
* @return EntityInfo
*/
private function getEntityInfo( ParserOutput $parserOutput ) {
- // set in ReferencedEntitiesDataUpdate
+ // set in ReferencedEntitiesDataUpdater
$entityIds = $parserOutput->getExtensionData(
'referenced-entities' );
if ( !is_array( $entityIds ) ) {
diff --git a/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
b/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
index ef3adbd..02ef68c 100644
--- a/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
+++ b/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
@@ -160,26 +160,26 @@
}
/**
- * @return ParserOutputDataUpdate[]
+ * @return ParserOutputDataUpdater[]
*/
private function getDataUpdates() {
$propertyDataTypeMatcher = new PropertyDataTypeMatcher(
$this->propertyDataTypeLookup );
$dataUpdates = array(
- new ReferencedEntitiesDataUpdate(
+ new ReferencedEntitiesDataUpdater(
$this->entityTitleLookup,
$this->externalEntityIdParser
),
- new ExternalLinksDataUpdate( $propertyDataTypeMatcher ),
- new ImageLinksDataUpdate( $propertyDataTypeMatcher )
+ new ExternalLinksDataUpdater( $propertyDataTypeMatcher
),
+ new ImageLinksDataUpdater( $propertyDataTypeMatcher )
);
if ( !empty( $this->preferredPageImagesProperties ) ) {
- $dataUpdates[] = new PageImagesDataUpdate(
$this->preferredPageImagesProperties );
+ $dataUpdates[] = new PageImagesDataUpdater(
$this->preferredPageImagesProperties );
}
if ( class_exists( 'GeoData' ) ) {
- $dataUpdates[] = new GeoDataDataUpdate(
+ $dataUpdates[] = new GeoDataDataUpdater(
$propertyDataTypeMatcher,
$this->preferredGeoDataProperties,
$this->globeUris
diff --git a/repo/includes/ParserOutput/ExternalLinksDataUpdate.php
b/repo/includes/ParserOutput/ExternalLinksDataUpdater.php
similarity index 96%
rename from repo/includes/ParserOutput/ExternalLinksDataUpdate.php
rename to repo/includes/ParserOutput/ExternalLinksDataUpdater.php
index 5bcd1fe..5c86cf4 100644
--- a/repo/includes/ParserOutput/ExternalLinksDataUpdate.php
+++ b/repo/includes/ParserOutput/ExternalLinksDataUpdater.php
@@ -19,7 +19,7 @@
* @author Katie Filbert < [email protected] >
* @author Thiemo Mättig
*/
-class ExternalLinksDataUpdate implements StatementDataUpdate {
+class ExternalLinksDataUpdater implements StatementDataUpdater {
/**
* @var PropertyDataTypeMatcher
diff --git a/repo/includes/ParserOutput/GeoDataDataUpdate.php
b/repo/includes/ParserOutput/GeoDataDataUpdater.php
similarity index 97%
rename from repo/includes/ParserOutput/GeoDataDataUpdate.php
rename to repo/includes/ParserOutput/GeoDataDataUpdater.php
index d484f83..7748840 100644
--- a/repo/includes/ParserOutput/GeoDataDataUpdate.php
+++ b/repo/includes/ParserOutput/GeoDataDataUpdater.php
@@ -29,7 +29,7 @@
* @license GNU GPL v2+
* @author Katie Filbert < [email protected] >
*/
-class GeoDataDataUpdate implements StatementDataUpdate {
+class GeoDataDataUpdater implements StatementDataUpdater {
/**
* @var PropertyDataTypeMatcher
@@ -63,7 +63,7 @@
array $globeUris
) {
if ( !class_exists( 'GeoData' ) ) {
- throw new RuntimeException( 'GeoDataDataUpdate requires
the GeoData extension '
+ throw new RuntimeException( 'GeoDataDataUpdater
requires the GeoData extension '
. 'to be enabled' );
}
diff --git a/repo/includes/ParserOutput/ImageLinksDataUpdate.php
b/repo/includes/ParserOutput/ImageLinksDataUpdater.php
similarity index 96%
rename from repo/includes/ParserOutput/ImageLinksDataUpdate.php
rename to repo/includes/ParserOutput/ImageLinksDataUpdater.php
index 1ebe2c9..3efc226 100644
--- a/repo/includes/ParserOutput/ImageLinksDataUpdate.php
+++ b/repo/includes/ParserOutput/ImageLinksDataUpdater.php
@@ -19,7 +19,7 @@
* @author Katie Filbert < [email protected] >
* @author Thiemo Mättig
*/
-class ImageLinksDataUpdate implements StatementDataUpdate {
+class ImageLinksDataUpdater implements StatementDataUpdater {
/**
* @var PropertyDataTypeMatcher
diff --git a/repo/includes/ParserOutput/PageImagesDataUpdate.php
b/repo/includes/ParserOutput/PageImagesDataUpdater.php
similarity index 95%
rename from repo/includes/ParserOutput/PageImagesDataUpdate.php
rename to repo/includes/ParserOutput/PageImagesDataUpdater.php
index 8302c1b..a3eaf2d 100644
--- a/repo/includes/ParserOutput/PageImagesDataUpdate.php
+++ b/repo/includes/ParserOutput/PageImagesDataUpdater.php
@@ -18,7 +18,7 @@
* @licence GNU GPL v2+
* @author Thiemo Mättig
*/
-class PageImagesDataUpdate implements StatementDataUpdate {
+class PageImagesDataUpdater implements StatementDataUpdater {
/**
* @var int[] Hash table of image property id strings pointing to
priorities (smaller numbers
@@ -49,7 +49,7 @@
}
/**
- * @see StatementDataUpdate::processStatement
+ * @see StatementDataUpdater::processStatement
*
* @param Statement $statement
*/
@@ -172,7 +172,7 @@
}
/**
- * @see ParserOutputDataUpdate::updateParserOutput
+ * @see ParserOutputDataUpdater::updateParserOutput
*
* @param ParserOutput $parserOutput
*/
diff --git a/repo/includes/ParserOutput/ParserOutputDataUpdate.php
b/repo/includes/ParserOutput/ParserOutputDataUpdater.php
similarity index 91%
rename from repo/includes/ParserOutput/ParserOutputDataUpdate.php
rename to repo/includes/ParserOutput/ParserOutputDataUpdater.php
index 6de0b7b..b1d8cd9 100644
--- a/repo/includes/ParserOutput/ParserOutputDataUpdate.php
+++ b/repo/includes/ParserOutput/ParserOutputDataUpdater.php
@@ -10,7 +10,7 @@
* @licence GNU GPL v2+
* @author Katie Filbert < [email protected] >
*/
-interface ParserOutputDataUpdate {
+interface ParserOutputDataUpdater {
/**
* Update extension data, properties or other data in ParserOutput.
diff --git a/repo/includes/ParserOutput/ReferencedEntitiesDataUpdate.php
b/repo/includes/ParserOutput/ReferencedEntitiesDataUpdater.php
similarity index 97%
rename from repo/includes/ParserOutput/ReferencedEntitiesDataUpdate.php
rename to repo/includes/ParserOutput/ReferencedEntitiesDataUpdater.php
index 9a753c6..f20c5ef 100644
--- a/repo/includes/ParserOutput/ReferencedEntitiesDataUpdate.php
+++ b/repo/includes/ParserOutput/ReferencedEntitiesDataUpdater.php
@@ -27,7 +27,7 @@
* @author Bene* < [email protected] >
* @author Thiemo Mättig
*/
-class ReferencedEntitiesDataUpdate implements StatementDataUpdate,
SiteLinkDataUpdate {
+class ReferencedEntitiesDataUpdater implements StatementDataUpdater,
SiteLinkDataUpdater {
/**
* @var EntityTitleLookup
diff --git a/repo/includes/ParserOutput/SiteLinkDataUpdate.php
b/repo/includes/ParserOutput/SiteLinkDataUpdater.php
similarity index 87%
rename from repo/includes/ParserOutput/SiteLinkDataUpdate.php
rename to repo/includes/ParserOutput/SiteLinkDataUpdater.php
index 5476683..c926c17 100644
--- a/repo/includes/ParserOutput/SiteLinkDataUpdate.php
+++ b/repo/includes/ParserOutput/SiteLinkDataUpdater.php
@@ -10,7 +10,7 @@
* @licence GNU GPL v2+
* @author Katie Filbert < [email protected] >
*/
-interface SiteLinkDataUpdate extends ParserOutputDataUpdate {
+interface SiteLinkDataUpdater extends ParserOutputDataUpdater {
/**
* Extract some data or do processing on a SiteLink during parsing.
diff --git a/repo/includes/ParserOutput/StatementDataUpdate.php
b/repo/includes/ParserOutput/StatementDataUpdater.php
similarity index 88%
rename from repo/includes/ParserOutput/StatementDataUpdate.php
rename to repo/includes/ParserOutput/StatementDataUpdater.php
index 8bfe2ca..a8d05bd 100644
--- a/repo/includes/ParserOutput/StatementDataUpdate.php
+++ b/repo/includes/ParserOutput/StatementDataUpdater.php
@@ -10,7 +10,7 @@
* @licence GNU GPL v2+
* @author Katie Filbert < [email protected] >
*/
-interface StatementDataUpdate extends ParserOutputDataUpdate {
+interface StatementDataUpdater extends ParserOutputDataUpdater {
/**
* Extract some data or do processing on a Statement during parsing.
diff --git
a/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputDataUpdaterTest.php
b/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputDataUpdaterTest.php
index 4a923c1..b573199 100644
---
a/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputDataUpdaterTest.php
+++
b/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputDataUpdaterTest.php
@@ -29,13 +29,13 @@
->disableOriginalConstructor()
->getMock();
- $statementDataUpdate = $this->getMock(
'Wikibase\Repo\ParserOutput\StatementDataUpdate' );
+ $statementDataUpdate = $this->getMock(
'Wikibase\Repo\ParserOutput\StatementDataUpdater' );
$statementDataUpdate->expects( $this->exactly( $statements ) )
->method( 'processStatement' );
$statementDataUpdate->expects( $this->once() )
->method( 'updateParserOutput' );
- $siteLinkDataUpdate = $this->getMock(
'Wikibase\Repo\ParserOutput\SiteLinkDataUpdate' );
+ $siteLinkDataUpdate = $this->getMock(
'Wikibase\Repo\ParserOutput\SiteLinkDataUpdater' );
$siteLinkDataUpdate->expects( $this->exactly( $siteLinks ) )
->method( 'processSiteLink' );
$siteLinkDataUpdate->expects( $this->once() )
@@ -80,7 +80,7 @@
return array(
array( array( null ) ),
array( array( 'notAnObject' ) ),
- array( array( $this->getMock(
'Wikibase\Repo\ParserOutput\ParserOutputDataUpdate' ) ) ),
+ array( array( $this->getMock(
'Wikibase\Repo\ParserOutput\ParserOutputDataUpdater' ) ) ),
);
}
diff --git
a/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputGeneratorTest.php
b/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputGeneratorTest.php
index 220d064..f9d86ff 100644
---
a/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputGeneratorTest.php
+++
b/repo/tests/phpunit/includes/ParserOutput/EntityParserOutputGeneratorTest.php
@@ -20,9 +20,9 @@
use Wikibase\Lib\Store\Sql\SqlEntityInfoBuilderFactory;
use Wikibase\Repo\LinkedData\EntityDataFormatProvider;
use Wikibase\Repo\ParserOutput\EntityParserOutputGenerator;
-use Wikibase\Repo\ParserOutput\ExternalLinksDataUpdate;
-use Wikibase\Repo\ParserOutput\ImageLinksDataUpdate;
-use Wikibase\Repo\ParserOutput\ReferencedEntitiesDataUpdate;
+use Wikibase\Repo\ParserOutput\ExternalLinksDataUpdater;
+use Wikibase\Repo\ParserOutput\ImageLinksDataUpdater;
+use Wikibase\Repo\ParserOutput\ReferencedEntitiesDataUpdater;
use Wikibase\View\Template\TemplateFactory;
/**
@@ -144,9 +144,9 @@
$propertyDataTypeMatcher = new PropertyDataTypeMatcher(
$this->getPropertyDataTypeLookup() );
$dataUpdates = array(
- new ExternalLinksDataUpdate( $propertyDataTypeMatcher ),
- new ImageLinksDataUpdate( $propertyDataTypeMatcher ),
- new ReferencedEntitiesDataUpdate(
+ new ExternalLinksDataUpdater( $propertyDataTypeMatcher
),
+ new ImageLinksDataUpdater( $propertyDataTypeMatcher ),
+ new ReferencedEntitiesDataUpdater(
$entityTitleLookup,
new BasicEntityIdParser()
)
diff --git
a/repo/tests/phpunit/includes/ParserOutput/ExternalLinksDataUpdateTest.php
b/repo/tests/phpunit/includes/ParserOutput/ExternalLinksDataUpdaterTest.php
similarity index 88%
rename from
repo/tests/phpunit/includes/ParserOutput/ExternalLinksDataUpdateTest.php
rename to
repo/tests/phpunit/includes/ParserOutput/ExternalLinksDataUpdaterTest.php
index 352878c..4329efa 100644
--- a/repo/tests/phpunit/includes/ParserOutput/ExternalLinksDataUpdateTest.php
+++ b/repo/tests/phpunit/includes/ParserOutput/ExternalLinksDataUpdaterTest.php
@@ -7,10 +7,10 @@
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Statement\StatementList;
-use Wikibase\Repo\ParserOutput\ExternalLinksDataUpdate;
+use Wikibase\Repo\ParserOutput\ExternalLinksDataUpdater;
/**
- * @covers Wikibase\Repo\ParserOutput\ExternalLinksDataUpdate
+ * @covers Wikibase\Repo\ParserOutput\ExternalLinksDataUpdater
*
* @group Wikibase
* @group WikibaseRepo
@@ -18,10 +18,10 @@
* @licence GNU GPL v2+
* @author Thiemo Mättig
*/
-class ExternalLinksDataUpdateTest extends PHPUnit_Framework_TestCase {
+class ExternalLinksDataUpdaterTest extends PHPUnit_Framework_TestCase {
/**
- * @return ExternalLinksDataUpdate
+ * @return ExternalLinksDataUpdater
*/
private function newInstance() {
$matcher = $this->getMockBuilder(
'Wikibase\Lib\Store\PropertyDataTypeMatcher' )
@@ -33,7 +33,7 @@
return $id->getSerialization() === 'P1';
} ) );
- return new ExternalLinksDataUpdate( $matcher );
+ return new ExternalLinksDataUpdater( $matcher );
}
/**
diff --git a/repo/tests/phpunit/includes/ParserOutput/GeoDataDataUpdateTest.php
b/repo/tests/phpunit/includes/ParserOutput/GeoDataDataUpdaterTest.php
similarity index 97%
rename from repo/tests/phpunit/includes/ParserOutput/GeoDataDataUpdateTest.php
rename to repo/tests/phpunit/includes/ParserOutput/GeoDataDataUpdaterTest.php
index 065464f..6d0d03a 100644
--- a/repo/tests/phpunit/includes/ParserOutput/GeoDataDataUpdateTest.php
+++ b/repo/tests/phpunit/includes/ParserOutput/GeoDataDataUpdaterTest.php
@@ -19,10 +19,10 @@
use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Statement\StatementList;
use Wikibase\Lib\Store\PropertyDataTypeMatcher;
-use Wikibase\Repo\ParserOutput\GeoDataDataUpdate;
+use Wikibase\Repo\ParserOutput\GeoDataDataUpdater;
/**
- * @covers Wikibase\Repo\ParserOutput\GeoDataDataUpdate;
+ * @covers Wikibase\Repo\ParserOutput\GeoDataDataUpdater;
*
* @group Wikibase
* @group WikibaseRepo
@@ -31,7 +31,7 @@
* @license GNU GPL v2+
* @author Katie Filbert < [email protected] >
*/
-class GeoDataDataUpdateTest extends \MediaWikiTestCase {
+class GeoDataDataUpdaterTest extends \MediaWikiTestCase {
private function willSkipTests() {
if ( !class_exists( 'GeoData' ) ) {
@@ -238,7 +238,7 @@
}
private function newGeoDataDataUpdate( array $preferredProperties ) {
- return new GeoDataDataUpdate(
+ return new GeoDataDataUpdater(
new PropertyDataTypeMatcher(
$this->getPropertyDataTypeLookup() ),
$preferredProperties,
array(
diff --git
a/repo/tests/phpunit/includes/ParserOutput/ImageLinksDataUpdateTest.php
b/repo/tests/phpunit/includes/ParserOutput/ImageLinksDataUpdaterTest.php
similarity index 88%
rename from
repo/tests/phpunit/includes/ParserOutput/ImageLinksDataUpdateTest.php
rename to repo/tests/phpunit/includes/ParserOutput/ImageLinksDataUpdaterTest.php
index ff04328..fb8feac 100644
--- a/repo/tests/phpunit/includes/ParserOutput/ImageLinksDataUpdateTest.php
+++ b/repo/tests/phpunit/includes/ParserOutput/ImageLinksDataUpdaterTest.php
@@ -7,10 +7,10 @@
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Statement\StatementList;
-use Wikibase\Repo\ParserOutput\ImageLinksDataUpdate;
+use Wikibase\Repo\ParserOutput\ImageLinksDataUpdater;
/**
- * @covers Wikibase\Repo\ParserOutput\ImageLinksDataUpdate
+ * @covers Wikibase\Repo\ParserOutput\ImageLinksDataUpdater
*
* @group Wikibase
* @group WikibaseRepo
@@ -18,10 +18,10 @@
* @licence GNU GPL v2+
* @author Thiemo Mättig
*/
-class ImageLinksDataUpdateTest extends PHPUnit_Framework_TestCase {
+class ImageLinksDataUpdaterTest extends PHPUnit_Framework_TestCase {
/**
- * @return ImageLinksDataUpdate
+ * @return ImageLinksDataUpdater
*/
private function newInstance() {
$matcher = $this->getMockBuilder(
'Wikibase\Lib\Store\PropertyDataTypeMatcher' )
@@ -33,7 +33,7 @@
return $id->getSerialization() === 'P1';
} ) );
- return new ImageLinksDataUpdate( $matcher );
+ return new ImageLinksDataUpdater( $matcher );
}
/**
diff --git
a/repo/tests/phpunit/includes/ParserOutput/PageImagesDataUpdateTest.php
b/repo/tests/phpunit/includes/ParserOutput/PageImagesDataUpdaterTest.php
similarity index 93%
rename from
repo/tests/phpunit/includes/ParserOutput/PageImagesDataUpdateTest.php
rename to repo/tests/phpunit/includes/ParserOutput/PageImagesDataUpdaterTest.php
index 2289778..7dec54f 100644
--- a/repo/tests/phpunit/includes/ParserOutput/PageImagesDataUpdateTest.php
+++ b/repo/tests/phpunit/includes/ParserOutput/PageImagesDataUpdaterTest.php
@@ -10,10 +10,10 @@
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Statement\StatementList;
-use Wikibase\Repo\ParserOutput\PageImagesDataUpdate;
+use Wikibase\Repo\ParserOutput\PageImagesDataUpdater;
/**
- * @covers Wikibase\Repo\ParserOutput\PageImagesDataUpdate
+ * @covers Wikibase\Repo\ParserOutput\PageImagesDataUpdater
*
* @since 0.5
*
@@ -23,15 +23,15 @@
* @license GNU GPL v2+
* @author Thiemo Mättig
*/
-class PageImagesDataUpdateTest extends PHPUnit_Framework_TestCase {
+class PageImagesDataUpdaterTest extends PHPUnit_Framework_TestCase {
/**
* @param string[] $propertyIds
*
- * @return PageImagesDataUpdate
+ * @return PageImagesDataUpdater
*/
private function newInstance( array $propertyIds ) {
- return new PageImagesDataUpdate( $propertyIds );
+ return new PageImagesDataUpdater( $propertyIds );
}
/**
@@ -58,7 +58,7 @@
*/
public function testConstructor( $propertyIds ) {
$instance = $this->newInstance( $propertyIds );
- $this->assertInstanceOf(
'Wikibase\Repo\ParserOutput\PageImagesDataUpdate', $instance );
+ $this->assertInstanceOf(
'Wikibase\Repo\ParserOutput\PageImagesDataUpdater', $instance );
}
public function constructorArgumentsProvider() {
diff --git
a/repo/tests/phpunit/includes/ParserOutput/ReferencedEntitiesDataUpdateTest.php
b/repo/tests/phpunit/includes/ParserOutput/ReferencedEntitiesDataUpdaterTest.php
similarity index 92%
rename from
repo/tests/phpunit/includes/ParserOutput/ReferencedEntitiesDataUpdateTest.php
rename to
repo/tests/phpunit/includes/ParserOutput/ReferencedEntitiesDataUpdaterTest.php
index 4965d27..80af7ad 100644
---
a/repo/tests/phpunit/includes/ParserOutput/ReferencedEntitiesDataUpdateTest.php
+++
b/repo/tests/phpunit/includes/ParserOutput/ReferencedEntitiesDataUpdaterTest.php
@@ -11,10 +11,10 @@
use Wikibase\DataModel\SiteLinkList;
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Statement\StatementList;
-use Wikibase\Repo\ParserOutput\ReferencedEntitiesDataUpdate;
+use Wikibase\Repo\ParserOutput\ReferencedEntitiesDataUpdater;
/**
- * @covers Wikibase\Repo\ParserOutput\ReferencedEntitiesDataUpdate
+ * @covers Wikibase\Repo\ParserOutput\ReferencedEntitiesDataUpdater
*
* @group Wikibase
* @group WikibaseRepo
@@ -23,7 +23,7 @@
* @licence GNU GPL v2+
* @author Thiemo Mättig
*/
-class ReferencedEntitiesDataUpdateTest extends MediaWikiTestCase {
+class ReferencedEntitiesDataUpdaterTest extends MediaWikiTestCase {
const UNIT_PREFIX = 'unit:';
@@ -38,7 +38,7 @@
/**
* @param int $count
*
- * @return ReferencedEntitiesDataUpdate
+ * @return ReferencedEntitiesDataUpdater
*/
private function newInstance( $count = 0 ) {
$entityTitleLookup = $this->getMockBuilder(
'Wikibase\Lib\Store\EntityTitleLookup' )
@@ -57,11 +57,11 @@
->method( 'parse' )
->will( $this->returnCallback( function( $id ) {
return new ItemId(
- substr( $id, strlen(
ReferencedEntitiesDataUpdateTest::UNIT_PREFIX ) )
+ substr( $id, strlen(
ReferencedEntitiesDataUpdaterTest::UNIT_PREFIX ) )
);
} ) );
- return new ReferencedEntitiesDataUpdate( $entityTitleLookup,
$entityidParser );
+ return new ReferencedEntitiesDataUpdater( $entityTitleLookup,
$entityidParser );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/249435
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If290acdddfec3f0ce5efbc373384ab9886bbb158
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
