Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/249457

Change subject: Make mysql-multiwrite use getInstance() factory spec
......................................................................

Make mysql-multiwrite use getInstance() factory spec

* This avoids "undefined index" errors for parameters like "timeout".
* It also avoid duplicate instance in PHP memory.

Change-Id: I80d38773057cb1ea03530711dd8c9412a9d80213
---
M wmf-config/CommonSettings.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/57/249457/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 9b63aef..3869a73 100755
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -287,7 +287,10 @@
 $wgObjectCaches['mysql-multiwrite'] = array(
        'class' => 'MultiWriteBagOStuff',
        'caches' => array(
-               0 => $wgObjectCaches['memcached-pecl'],
+               0 => array(
+                       'factory' => array( 'ObjectCache', 'getInstance' ),
+                       'args' => array( 'memcached-pecl' )
+               ),
                1 => array(
                        'class' => 'SqlBagOStuff',
                        'servers' => $pcServers,

-- 
To view, visit https://gerrit.wikimedia.org/r/249457
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80d38773057cb1ea03530711dd8c9412a9d80213
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to