BearND has uploaded a new change for review. https://gerrit.wikimedia.org/r/249689
Change subject: Fix test for 404 ...................................................................... Fix test for 404 Weird: Sometimes I get 'https://restbase.org/errors/not_found#page_revisions' and then 'missingtitle' when running the same check a few seconds later. Probably a RESTBase inconsistency. Change-Id: I6ab324d3d9ef28c45bc69fdb19a24e702d1a6254 --- M test/features/mobile-html-sections/pagecontent.js 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps refs/changes/89/249689/1 diff --git a/test/features/mobile-html-sections/pagecontent.js b/test/features/mobile-html-sections/pagecontent.js index 04a781e..9192b92 100644 --- a/test/features/mobile-html-sections/pagecontent.js +++ b/test/features/mobile-html-sections/pagecontent.js @@ -104,7 +104,11 @@ var body = res.body; assert.deepEqual(res.status, 404); assert.deepEqual(body.status, 404); - assert.deepEqual(body.type, 'missingtitle'); + + // Weird: sometimes I get 'missingtitle' and other times I get 'https://restbase.org/errors/not_found#page_revisions' + //assert.deepEqual(body.type, 'missingtitle'); + //assert.deepEqual(body.type, 'https://restbase.org/errors/not_found#page_revisions'); + assert.deepEqual(body.title, "The page you requested doesn't exist"); }); }); -- To view, visit https://gerrit.wikimedia.org/r/249689 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ab324d3d9ef28c45bc69fdb19a24e702d1a6254 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/mobileapps Gerrit-Branch: master Gerrit-Owner: BearND <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
