jenkins-bot has submitted this change and it was merged.
Change subject: Fix type hinting in doLinkCacheQuery() and buildUserList()
......................................................................
Fix type hinting in doLinkCacheQuery() and buildUserList()
I don't know why but currently but the behavior is different versions.
Change-Id: I57ccaab8c729fff305c1f6e968882a180bd129d4
---
M includes/specials/SpecialNewsletter.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
01tonythomas: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialNewsletter.php
b/includes/specials/SpecialNewsletter.php
index 6a90fc5..01dc265 100644
--- a/includes/specials/SpecialNewsletter.php
+++ b/includes/specials/SpecialNewsletter.php
@@ -229,11 +229,11 @@
* Batch query to determine whether user pages and user talk pages exist
* or not and add them to LinkCache
*
- * @param UserArray $users
+ * @param Iterator $users
*
* @return string
*/
- private function doLinkCacheQuery( UserArray $users ) {
+ private function doLinkCacheQuery( Iterator $users ) {
$batch = new LinkBatch();
foreach ( $users as $user ) {
$batch->addObj( $user->getUserPage() );
@@ -246,11 +246,11 @@
/**
* Get a list of users with user-related links next to each username
*
- * @param UserArray $users
+ * @param Iterator $users
*
* @return string
*/
- private function buildUserList( UserArray $users ) {
+ private function buildUserList( Iterator $users ) {
$str = '';
foreach ( $users as $user ) {
$str .= Html::rawElement(
--
To view, visit https://gerrit.wikimedia.org/r/249442
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57ccaab8c729fff305c1f6e968882a180bd129d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
Gerrit-Reviewer: 01tonythomas <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
