Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249730
Change subject: TitleWidget: Sort results correctly
......................................................................
TitleWidget: Sort results correctly
Bug: T117039
Change-Id: Ie86c1751dacb5c32afe708b354809b914a54ea51
---
M resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/30/249730/1
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
index 0ef5095..f764513 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
@@ -180,7 +180,9 @@
redirect: suggestionPage.redirect !== undefined,
disambiguation: OO.getProp( suggestionPage,
'pageprops', 'disambiguation' ) !== undefined,
imageUrl: OO.getProp( suggestionPage,
'thumbnail', 'source' ),
- description: OO.getProp( suggestionPage,
'terms', 'description' )
+ description: OO.getProp( suggestionPage,
'terms', 'description' ),
+ // sort index
+ index: suggestionPage.index
};
// Throw away pages from wrong namespaces. This can
happen when 'showRedirectTargets' is true
@@ -201,6 +203,10 @@
}
}
+ titles.sort( function ( a, b ) {
+ return pageData[ a ].index - pageData[ b ].index;
+ } );
+
// If not found, run value through mw.Title to avoid treating a
match as a
// mismatch where normalisation would make them matching (bug
48476)
--
To view, visit https://gerrit.wikimedia.org/r/249730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie86c1751dacb5c32afe708b354809b914a54ea51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
