jenkins-bot has submitted this change and it was merged.
Change subject: Suppress delete button icon on empty search history page
......................................................................
Suppress delete button icon on empty search history page
Bug: T116449
Change-Id: I2aff03ccb90dba61202aece6fad49ad320f23874
---
M app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java
b/app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java
index abe8d97..185af61 100644
--- a/app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java
+++ b/app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java
@@ -13,6 +13,7 @@
import android.view.View;
import android.view.ViewGroup;
import android.widget.AdapterView;
+import android.widget.ImageView;
import android.widget.ListView;
import android.widget.TextView;
@@ -25,6 +26,7 @@
private View container;
private ListView recentSearchesList;
private RecentSearchesAdapter adapter;
+ private ImageView deleteButton;
public RecentSearchesFragment() {
}
@@ -35,6 +37,7 @@
searchFragment =
(SearchArticlesFragment)getActivity().getSupportFragmentManager().findFragmentById(R.id.search_fragment);
this.container = rootView.findViewById(R.id.recent_searches_container);
recentSearchesList = (ListView)
rootView.findViewById(R.id.recent_searches_list);
+ deleteButton = (ImageView)
rootView.findViewById(R.id.recent_searches_delete_button);
return rootView;
}
@@ -94,6 +97,8 @@
return;
}
adapter.swapCursor(cursorLoader);
+ boolean visible = recentSearchesList.getCount() > 0;
+ deleteButton.setVisibility(visible ? View.VISIBLE : View.INVISIBLE);
getActivity().supportInvalidateOptionsMenu();
}
--
To view, visit https://gerrit.wikimedia.org/r/248565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2aff03ccb90dba61202aece6fad49ad320f23874
Gerrit-PatchSet: 5
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Wikinaut <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Wikinaut <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
