Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249782
Change subject: build: Enable phpcs rule
'MediaWiki.VariableAnalysis.UnusedGlobalVariables' and make pass
......................................................................
build: Enable phpcs rule 'MediaWiki.VariableAnalysis.UnusedGlobalVariables' and
make pass
Change-Id: I1af3e34531ff9d02183a7ad0052712d9f137609c
---
M includes/NotifUser.php
M maintenance/removeInvalidTargetPage.php
M phpcs.xml
3 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/82/249782/1
diff --git a/includes/NotifUser.php b/includes/NotifUser.php
index 0b88336..7fcb0c0 100644
--- a/includes/NotifUser.php
+++ b/includes/NotifUser.php
@@ -181,7 +181,6 @@
* @return boolean User has received messages
*/
public function hasMessages( $cached = true ) {
- global $wgEchoConfig;
$section = EchoAttributeManager::MESSAGE;
$memcKey = $this->getHasMessagesKey();
diff --git a/maintenance/removeInvalidTargetPage.php
b/maintenance/removeInvalidTargetPage.php
index fe7d8ac..e865af1 100644
--- a/maintenance/removeInvalidTargetPage.php
+++ b/maintenance/removeInvalidTargetPage.php
@@ -23,8 +23,6 @@
}
public function execute() {
- global $wgEchoCluster;
-
$dbFactory = MWEchoDbFactory::newFromDefault();
$dbw = $dbFactory->getEchoDb( DB_MASTER );
$dbr = $dbFactory->getEchoDb( DB_SLAVE );
diff --git a/phpcs.xml b/phpcs.xml
index 06f29d6..a32c10e 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -3,7 +3,6 @@
<file>.</file>
<rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.Files.LineLength"/>
- <exclude
name="MediaWiki.VariableAnalysis.UnusedGlobalVariables"/>
</rule>
<arg name="encoding" value="utf8"/>
<arg name="extensions" value="php,php5,inc"/>
--
To view, visit https://gerrit.wikimedia.org/r/249782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1af3e34531ff9d02183a7ad0052712d9f137609c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
