Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249771
Change subject: build: Enable phpcs rule
'Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma' and make pass
......................................................................
build: Enable phpcs rule
'Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma' and make pass
Change-Id: I5493cb692525ab6c0d560aebbe131f40b6016232
---
M phpcs.xml
M tests/phpunit/DiscussionParserTest.php
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/71/249771/1
diff --git a/phpcs.xml b/phpcs.xml
index d76bf9d..d6da2af 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -3,7 +3,6 @@
<file>.</file>
<rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.Files.LineLength"/>
- <exclude
name="Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma"/>
<exclude
name="Generic.PHP.ForbiddenFunctions.FoundWithAlternative"/>
<exclude
name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix"/>
<exclude name="MediaWiki.Usage.DirUsage.FunctionFound"/>
diff --git a/tests/phpunit/DiscussionParserTest.php
b/tests/phpunit/DiscussionParserTest.php
index fe6bb4a..05de7c7 100644
--- a/tests/phpunit/DiscussionParserTest.php
+++ b/tests/phpunit/DiscussionParserTest.php
@@ -415,7 +415,7 @@
line 3
line 4
TEXT
- ,
+,
<<<TEXT
line 1
line c
@@ -831,7 +831,7 @@
== Section 3 ==
Hai [[User:Bsitu|Bsitu]] ([[User talk:Bsitu|talk]]) $ts
TEXT
- ,
+,
<<<TEXT
== Section 1 ==
I do not like you. [[User:Jorm|Jorm]] ([[User talk:Jorm|talk]]) $ts
@@ -878,7 +878,7 @@
''The Boston Post'' source that was used in the reception section has a couple
of problems. First, it's actually a repost of ''The Washington Post'', but
''The Washington Post'' doesn't allow the Internet Archive to preserve it.
Should it still be sourced to Boston or to Washington? Second, it seems to be a
lot of analysis that can't be summed up easily without trimming it out, and
doesn't really fit with the reception section and should probably moved next to
Wilson's testimony. Any suggestions? --[[User:RAN1|RAN1]] ([[User
talk:RAN1|talk]]) 01:44, 11 December 2014 (UTC)
TEXT
- ,
+,
<<<TEXT
== Washington Post Reception Source ==
--
To view, visit https://gerrit.wikimedia.org/r/249771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5493cb692525ab6c0d560aebbe131f40b6016232
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
