jenkins-bot has submitted this change and it was merged.
Change subject: Upgrade MediaWiki-Codesniffer to 0.4.0
......................................................................
Upgrade MediaWiki-Codesniffer to 0.4.0
And fix spotted issues.
Change-Id: I9669a0aa55fb44198fb831017edd7e2a0690a77a
---
M composer.json
M tests/job/MassMessageJobTest.php
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Paladox: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index a03d4b1..139e23a 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
- "mediawiki/mediawiki-codesniffer": "0.3.0"
+ "mediawiki/mediawiki-codesniffer": "0.4.0"
},
"scripts": {
"test": [
diff --git a/tests/job/MassMessageJobTest.php b/tests/job/MassMessageJobTest.php
index 148924d..01909e0 100644
--- a/tests/job/MassMessageJobTest.php
+++ b/tests/job/MassMessageJobTest.php
@@ -35,7 +35,7 @@
}
$subj = $this->simulateJob( $target );
$target = Title::newFromText( 'Project:Testing1234' ); // Clear
cache?
- //$this->assertTrue( $target->exists() ); // Message was created
+ // $this->assertTrue( $target->exists() ); // Message was
created
$text = WikiPage::factory( $target )->getContent( Revision::RAW
)->getNativeData();
$this->assertEquals(
"== $subj ==\n\nThis is a message.\n<!-- Message sent
by User:Admin@metawiki" .
@@ -56,7 +56,7 @@
$this->markTestSkipped( "This test requires the
LiquidThreads extension" );
}
$target = Title::newFromText( 'Project:LQT test' );
- //$this->assertTrue( LqtDispatch::isLqtPage( $target ) ); //
Check that it worked
+ // $this->assertTrue( LqtDispatch::isLqtPage( $target ) ); //
Check that it worked
$subject = $this->simulateJob( $target );
$this->assertTrue( Title::newFromText( 'Thread:' . $proj .
':LQT test/' . $subject )->exists() );
}
--
To view, visit https://gerrit.wikimedia.org/r/241748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9669a0aa55fb44198fb831017edd7e2a0690a77a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: Wctaiwan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
