jenkins-bot has submitted this change and it was merged.
Change subject: build: Enable phpcs rule
'Generic.PHP.ForbiddenFunctions.FoundWithAlternative' and make pass
......................................................................
build: Enable phpcs rule 'Generic.PHP.ForbiddenFunctions.FoundWithAlternative'
and make pass
Change-Id: Ib883696662745641ee8b59ddb4fe478a44c46a02
---
M phpcs.xml
M scripts/generatecss.php
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/phpcs.xml b/phpcs.xml
index d6da2af..ee4093a 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -3,7 +3,6 @@
<file>.</file>
<rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.Files.LineLength"/>
- <exclude
name="Generic.PHP.ForbiddenFunctions.FoundWithAlternative"/>
<exclude
name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix"/>
<exclude name="MediaWiki.Usage.DirUsage.FunctionFound"/>
<exclude
name="MediaWiki.VariableAnalysis.UnusedGlobalVariables"/>
diff --git a/scripts/generatecss.php b/scripts/generatecss.php
index 669b9b6..4e47d80 100644
--- a/scripts/generatecss.php
+++ b/scripts/generatecss.php
@@ -1,5 +1,5 @@
<?php
-if ( sizeof( $argv ) < 3 ) {
+if ( count( $argv ) < 3 ) {
print "Call with 2 arguments: the path to the load url and the file to
output to";
exit();
}
--
To view, visit https://gerrit.wikimedia.org/r/249772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib883696662745641ee8b59ddb4fe478a44c46a02
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
