jenkins-bot has submitted this change and it was merged.
Change subject: build: Enable phpcs rule
'PSR2.Classes.PropertyDeclaration.ScopeMissing' and make pass
......................................................................
build: Enable phpcs rule 'PSR2.Classes.PropertyDeclaration.ScopeMissing' and
make pass
Change-Id: I96b295bba43185085631722e10a5e5cfa7ecf27f
---
M includes/DataOutputFormatter.php
M phpcs.xml
M tests/NotificationsTest.php
3 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/DataOutputFormatter.php b/includes/DataOutputFormatter.php
index ba54584..e508274 100644
--- a/includes/DataOutputFormatter.php
+++ b/includes/DataOutputFormatter.php
@@ -8,7 +8,7 @@
/**
* @var array type => class
*/
- static $formatters = array(
+ protected static $formatters = array(
'flyout' => 'EchoFlyoutFormatter'
);
diff --git a/phpcs.xml b/phpcs.xml
index 585dc29..2077627 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -6,7 +6,6 @@
<exclude
name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix"/>
<exclude
name="MediaWiki.VariableAnalysis.UnusedGlobalVariables"/>
<exclude
name="MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect"/>
- <exclude name="PSR2.Classes.PropertyDeclaration.ScopeMissing"/>
<exclude name="PSR2.Classes.PropertyDeclaration.VarUsed"/>
<exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/>
</rule>
diff --git a/tests/NotificationsTest.php b/tests/NotificationsTest.php
index 8babc5a..f385d75 100644
--- a/tests/NotificationsTest.php
+++ b/tests/NotificationsTest.php
@@ -8,7 +8,9 @@
class NotificationsTest extends MediaWikiTestCase {
/** @var User $sysop */
+ // @codingStandardsIgnoreStart
var $sysop;
+ // @codingStandardsIgnoreEnd
public function setUp() {
parent::setUp();
--
To view, visit https://gerrit.wikimedia.org/r/249777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96b295bba43185085631722e10a5e5cfa7ecf27f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
