jenkins-bot has submitted this change and it was merged.

Change subject: build: Enable phpcs rule 
'MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect' and make pass
......................................................................


build: Enable phpcs rule 
'MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect' and make pass

Change-Id: If230a568463a048b59138850ededa2b02fb61f46
---
M includes/formatters/UserRightsPresentationModel.php
M phpcs.xml
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/formatters/UserRightsPresentationModel.php 
b/includes/formatters/UserRightsPresentationModel.php
index 37c7380..ee1abc2 100644
--- a/includes/formatters/UserRightsPresentationModel.php
+++ b/includes/formatters/UserRightsPresentationModel.php
@@ -28,7 +28,7 @@
 
                                // Get the localized group names, bug 55338
                                $groups = array();
-                               foreach( $extra[$action] as $group ) {
+                               foreach ( $extra[$action] as $group ) {
                                        $msg = $this->msg( 'group-' . $group );
                                        $groups[] = $msg->isBlank() ? $group : 
$msg->text();
                                }
diff --git a/phpcs.xml b/phpcs.xml
index 6f03510..06f29d6 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -4,7 +4,6 @@
        <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
                <exclude name="Generic.Files.LineLength"/>
                <exclude 
name="MediaWiki.VariableAnalysis.UnusedGlobalVariables"/>
-               <exclude 
name="MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect"/>
        </rule>
        <arg name="encoding" value="utf8"/>
        <arg name="extensions" value="php,php5,inc"/>

-- 
To view, visit https://gerrit.wikimedia.org/r/249781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If230a568463a048b59138850ededa2b02fb61f46
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to