Daniel Werner has submitted this change and it was merged. Change subject: (minor) fix edgecase in aliases UI when edited by multiple users ......................................................................
(minor) fix edgecase in aliases UI when edited by multiple users - this fixes a very special edgecase in the aliases UI: when 2 users were editing aliases of the same entity and user 1 removed all aliases while they are still displayed for user 2, a JS error occurred when user 2 was trying to add a new alias and then tries t remove it again. the bug happened cause the UI was expecting an array of aliases coming back from the API but got no aliases at all instead. Change-Id: Id6c0884b06efc294369043115ebb2fd18cf58fd6 --- M lib/resources/wikibase.ui.PropertyEditTool.EditableAliases.js 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved Henning Snater: Checked; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39367 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6c0884b06efc294369043115ebb2fd18cf58fd6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
