jenkins-bot has submitted this change and it was merged.
Change subject: Fix unwritable cluster errors
......................................................................
Fix unwritable cluster errors
Prod has been complaining recently about
Received job for unwritable cluster 0.
It turns out this is because I added a third parameter to MassIndex::build(),
which defaults to 'all clusters', but there was already a call site mistakenly
sending three arguments to a function that only has two. Gotta love php not
complaining about that months ago...
Bug: T116576
Change-Id: I1d4ed9ef45cb1328ae1843aa8a5acdbce5d2c002
---
M includes/Hooks.php
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
Objections:
Cindy-the-browser-test-bot: There's a problem with this change, please improve
diff --git a/includes/Hooks.php b/includes/Hooks.php
index e006e2d..c849685 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -314,7 +314,6 @@
JobQueueGroup::singleton()->push(
Job\MassIndex::build(
array( WikiPage::factory( $title ) ),
- false,
Updater::INDEX_EVERYTHING
)
);
--
To view, visit https://gerrit.wikimedia.org/r/249669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d4ed9ef45cb1328ae1843aa8a5acdbce5d2c002
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Cindy-the-browser-test-bot <[email protected]>
Gerrit-Reviewer: DCausse <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
