jenkins-bot has submitted this change and it was merged.
Change subject: Styling tweaks for inline interwiki search
......................................................................
Styling tweaks for inline interwiki search
To make this look reasonable had to adjust the other styling around
it, I think this now makes more sense too
* moved p tag top margin to .searchresults, the only p tag is at the top
of search results anyways,
* moved the left margins on every element inside .searchresults
to .searchresults for consistency
* removed bottom padding from .searchresults p completely, this is
unnecessary. The top margin of .mw-search-results (.3em) along
with the bottom margin of generic p tags (.5em) is plenty on its own
* strip the top margin on mw-search-interwiki-header when it comes
immediatly after .mw-search-nonefound for better spacing to match
mockup
Bug: T112349
Change-Id: I3dec110e1ac0ab9c3dab1a3f7e6c2b747f2e28c8
---
M resources/src/mediawiki.special/mediawiki.special.search.css
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
JGirault: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.special/mediawiki.special.search.css
b/resources/src/mediawiki.special/mediawiki.special.search.css
index b869314..0c8e709 100644
--- a/resources/src/mediawiki.special/mediawiki.special.search.css
+++ b/resources/src/mediawiki.special/mediawiki.special.search.css
@@ -15,18 +15,24 @@
display: inline !ie;
}
.searchresults {
+ margin: 1em 0 1em .4em;
}
-.searchresults p {
- margin-left: 0.4em;
- margin-top: 1em;
- margin-bottom: 1.2em;
+/* needs extra specificity to override `.mw-body p` selector */
+.mw-body p.mw-search-nonefound {
+ margin: 0;
+}
+.mw-search-interwiki-header {
+ font-weight: bold;
+}
+.mw-search-nonefound + .mw-search-interwiki-header {
+ margin-top: 0;
}
div.searchresult {
font-size: 95%;
width: 38em;
}
.mw-search-results {
- margin-left: 0.4em;
+ margin-left: 0;
float: left;
}
.mw-search-results li {
--
To view, visit https://gerrit.wikimedia.org/r/249064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dec110e1ac0ab9c3dab1a3f7e6c2b747f2e28c8
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: JGirault <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
