Spage has submitted this change and it was merged. Change subject: Don't leak e3 and murmur3 into global scope. ......................................................................
Don't leak e3 and murmur3 into global scope. In ?debug=1 mode I noticed global (window) scope had e3 and murmur3 defined. This file is the culprit. I changed it to declare within an immediate anonymous function. Change-Id: I75423161ab54697f33aad5ba58751f01ddddc237 --- M lib/murmur3.js 1 file changed, 58 insertions(+), 56 deletions(-) Approvals: Spage: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38819 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75423161ab54697f33aad5ba58751f01ddddc237 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Alex Monk <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
