jenkins-bot has submitted this change and it was merged.

Change subject: Fix "Notice: Undefined property: Category::$mId" errors
......................................................................


Fix "Notice: Undefined property: Category::$mId" errors

This should also improve performance while at it.

Change-Id: Ib62ce801f597c653d0a8d5fc19b81c1ce8e0f5f2
---
M includes/Category.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Category.php b/includes/Category.php
index 1b05f33..3860172 100644
--- a/includes/Category.php
+++ b/includes/Category.php
@@ -327,7 +327,7 @@
                        array( 'LOCK IN SHARE MODE' )
                );
 
-               if ( $this->mId ) {
+               if ( $this->mID ) {
                        # The category row already exists, so do a plain UPDATE 
instead
                        # of INSERT...ON DUPLICATE KEY UPDATE to avoid creating 
a gap
                        # in the cat_id sequence. The row may or may not be 
"affected".

-- 
To view, visit https://gerrit.wikimedia.org/r/249890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib62ce801f597c653d0a8d5fc19b81c1ce8e0f5f2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to