Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249941
Change subject: Allow empty lang parameter
......................................................................
Allow empty lang parameter
This did not cause visible errors or warnings, it just added the page to
syntaxhighlight-error-category, for which there's no test.
Bug: T117125
Change-Id: If89535103080de8a8bfc306b1ccfe85ce3c9951b
---
M SyntaxHighlight_GeSHi.class.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi
refs/changes/41/249941/1
diff --git a/SyntaxHighlight_GeSHi.class.php b/SyntaxHighlight_GeSHi.class.php
index a13fb43..c1f3b66 100644
--- a/SyntaxHighlight_GeSHi.class.php
+++ b/SyntaxHighlight_GeSHi.class.php
@@ -207,7 +207,8 @@
$status = new Status;
$lexer = self::getLexer( $lang );
- if ( $lexer === null && $lang !== null ) {
+ // Loose check for lang since the parser tag defaults to empty
string.
+ if ( $lexer === null && $lang != null ) {
$status->warning(
'syntaxhighlight-error-unknown-language', $lang );
}
--
To view, visit https://gerrit.wikimedia.org/r/249941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If89535103080de8a8bfc306b1ccfe85ce3c9951b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Spage <sp...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
