Eileen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249958
Change subject: Add deprecation comments to 4.2 custom api
......................................................................
Add deprecation comments to 4.2 custom api
T117143
Change-Id: Ib2bc898bc4f2b9579d0cb3156b1c68d4edfe9de1
---
M CRM/Core/BAO/EntityTag.php
M api/v3/EntityTag.php
2 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/civicrm
refs/changes/58/249958/1
diff --git a/CRM/Core/BAO/EntityTag.php b/CRM/Core/BAO/EntityTag.php
index e69f2c9..4fb4f0f 100644
--- a/CRM/Core/BAO/EntityTag.php
+++ b/CRM/Core/BAO/EntityTag.php
@@ -64,7 +64,11 @@
}
/**
- * Get array of tag details the contact belongs to.
+ * @deprecated
+ *
+ * This is ported from wmf 4.2 but (hopefully) no longer used
+ * and should be removed after another a few more checks to ensure it
+ * is not called.
*
* @param int $entityID id of the entity usually the contactID.
* @param string $entityTable name of the entity table usually
'civicrm_contact'
diff --git a/api/v3/EntityTag.php b/api/v3/EntityTag.php
index b6e2bdf..2992e29 100644
--- a/api/v3/EntityTag.php
+++ b/api/v3/EntityTag.php
@@ -70,10 +70,21 @@
$params['entity_table']['api.default'] = 'civicrm_contact';
}
+/**
+ * @deprecated
+ *
+ * This is ported from wmf 4.2 but (hopefully) no longer used
+ * and should be removed after another a few more checks to ensure it
+ * is not called.
+ *
+ * @param $params
+ * @return array
+ */
function civicrm_api3_entity_tag_getdetails($params) {
$values = CRM_Core_BAO_EntityTag::getTagDetails($params['entity_id'],
$params['entity_table']);
return civicrm_api3_create_success($values, $params);
}
+
function _civicrm_api3_entity_tag_getdetails_spec(&$params) {
$params['entity_id']['api.required'] = 1;
$params['entity_id']['api.aliases'] = array('contact_id');
--
To view, visit https://gerrit.wikimedia.org/r/249958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2bc898bc4f2b9579d0cb3156b1c68d4edfe9de1
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/civicrm
Gerrit-Branch: master-plus-4.6.9
Gerrit-Owner: Eileen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
