Aaron Schulz has submitted this change and it was merged.
Change subject: When logging perf stats, include wfWikiId() in metric key
......................................................................
When logging perf stats, include wfWikiId() in metric key
...so that modules are easily locatable in multi-wiki environments (like
Wikimedia's).
Change-Id: I60b9eb6177294eedceaacd5398545a30ad896f11
---
M common/Hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
diff --git a/common/Hooks.php b/common/Hooks.php
index 945aad3..792e78a 100644
--- a/common/Hooks.php
+++ b/common/Hooks.php
@@ -221,7 +221,8 @@
$stats = RequestContext::getMain()->getStats();
}
- $stats->timing(
"scribunto.traces.{$moduleName}__{$functionName}", $timing );
+ $metricKey = sprintf( 'scribunto.traces.%s__%s__%s',
wfWikiId(), $moduleName, $functionName );
+ $stats->timing( $metricKey, $timing );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/249945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60b9eb6177294eedceaacd5398545a30ad896f11
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
