BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249969
Change subject: Restrict WebView debug enabled call to debug APKs only
......................................................................
Restrict WebView debug enabled call to debug APKs only
Only call WebView.setWebContentsDebuggingEnabled
if app is built in debug mode. No need to call this for release
builds since the default is false.
This patch may or may not fix T113052 but it will change the kind
of outer stack traces we get for this issue (the inner most part, though,
should stay the same). It will postpone the missing WebView issue
until later. The call happens very early when the Application object is created.
Bug: T113052
Change-Id: Ia9bd9869f7f5fc8004782d996cb4d379e69d8b24
---
M app/src/main/java/org/wikipedia/WikipediaApp.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/69/249969/1
diff --git a/app/src/main/java/org/wikipedia/WikipediaApp.java
b/app/src/main/java/org/wikipedia/WikipediaApp.java
index f1c7d10..e5f92ad 100644
--- a/app/src/main/java/org/wikipedia/WikipediaApp.java
+++ b/app/src/main/java/org/wikipedia/WikipediaApp.java
@@ -612,8 +612,8 @@
@TargetApi(Build.VERSION_CODES.KITKAT)
private void enableWebViewDebugging() {
- if (ApiUtil.hasKitKat()) {
- WebView.setWebContentsDebuggingEnabled(BuildConfig.DEBUG);
+ if (BuildConfig.DEBUG && ApiUtil.hasKitKat()) {
+ WebView.setWebContentsDebuggingEnabled(true);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/249969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9bd9869f7f5fc8004782d996cb4d379e69d8b24
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
