Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249971
Change subject: jobqueue: Pass count value delta instead of $type for the
inserts_actual metric
......................................................................
jobqueue: Pass count value delta instead of $type for the inserts_actual metric
Follows-up 4844595. Which wrongly passed the delta as $type parameter.
This resulted in the creation of "jobqueue.inserts_actual.50" and other
random buckets.
The "all" key also got incremented with 1, but doesn't reflect the actual
value in any meaningful way (besides the number of data points pushed
to statsd).
Change-Id: Ic93e06946ce3fcf0c21d2b7504fb10b3711c6e2b
---
M includes/jobqueue/JobQueueRedis.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/249971/1
diff --git a/includes/jobqueue/JobQueueRedis.php
b/includes/jobqueue/JobQueueRedis.php
index 1e957c2..deb5aa5 100644
--- a/includes/jobqueue/JobQueueRedis.php
+++ b/includes/jobqueue/JobQueueRedis.php
@@ -219,7 +219,7 @@
}
}
JobQueue::incrStats( 'inserts', $this->type, count(
$items ) );
- JobQueue::incrStats( 'inserts_actual', $pushed );
+ JobQueue::incrStats( 'inserts_actual', $this->type,
$pushed );
JobQueue::incrStats( 'dupe_inserts', $this->type,
count( $items ) - $failed - $pushed );
if ( $failed > 0 ) {
--
To view, visit https://gerrit.wikimedia.org/r/249971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic93e06946ce3fcf0c21d2b7504fb10b3711c6e2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.27.0-wmf.4
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
