jenkins-bot has submitted this change and it was merged.

Change subject: EntityTermsView.php: Escape href parameter
......................................................................


EntityTermsView.php: Escape href parameter

Bug: T116472
Change-Id: I9311a7be67cc559e5dcc68f0369f31260a7039c3
---
M view/src/EntityTermsView.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Adrian Lang: Looks good to me, approved
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/view/src/EntityTermsView.php b/view/src/EntityTermsView.php
index 9bf16f6..6bb7e6b 100644
--- a/view/src/EntityTermsView.php
+++ b/view/src/EntityTermsView.php
@@ -218,9 +218,10 @@
                        'td',
                        $languageCode,
                        $this->templateFactory->render( 
'wikibase-entitytermsforlanguageview-language',
-                               $title === null
+                               htmlspecialchars( $title === null
                                        ? '#'
-                                       : $title->getLocalURL( array( 'setlang' 
=> $languageCode ) ),
+                                       : $title->getLocalURL( array( 'setlang' 
=> $languageCode ) )
+                               ),
                                htmlspecialchars( 
$this->languageNameLookup->getName( $languageCode, $this->languageCode ) )
                        ),
                        $this->templateFactory->render( 'wikibase-labelview',

-- 
To view, visit https://gerrit.wikimedia.org/r/248615
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9311a7be67cc559e5dcc68f0369f31260a7039c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to