jenkins-bot has submitted this change and it was merged.
Change subject: Update description of LinkCache::forUpdate()
......................................................................
Update description of LinkCache::forUpdate()
The $mForUpdate flag no longer causes the FOR UPDATE option to be added.
This was at first only true for some values of $wgAntiLockFlags (since
r9248 / ba8a00bcb833), though since 12757b50f8da (when the setting was
removed), is always the case.
The added text is based on the description for $wgAntiLockFlags.
Change-Id: I02a3e2df37ec40c7e36ae6210c8263f13d9e3e5b
---
M includes/cache/LinkCache.php
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/cache/LinkCache.php b/includes/cache/LinkCache.php
index 3db84a6..4c45686 100644
--- a/includes/cache/LinkCache.php
+++ b/includes/cache/LinkCache.php
@@ -88,7 +88,11 @@
}
/**
- * General accessor to get/set whether SELECT FOR UPDATE should be used
+ * General accessor to get/set whether the master DB should be used
+ *
+ * This used to also set the FOR UPDATE option (locking the rows read
+ * in order to avoid link table inconsistency), which was later removed
+ * for performance on wikis with a high edit rate.
*
* @param bool $update
* @return bool
--
To view, visit https://gerrit.wikimedia.org/r/249975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02a3e2df37ec40c7e36ae6210c8263f13d9e3e5b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
