Tinaj1234 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249996
Change subject: Sort newsletter names and few minor changes on ManageNewsletter
......................................................................
Sort newsletter names and few minor changes on ManageNewsletter
Sort the newsletters alphabetically and also display only the newsletters
to which the logged in user is a publisher.
Bug: T117043
Change-Id: I892c00c855593bcb4ff79cf9259a79d8bc1f77c7
---
M includes/specials/pagers/NewsletterManageTablePager.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/96/249996/1
diff --git a/includes/specials/pagers/NewsletterManageTablePager.php
b/includes/specials/pagers/NewsletterManageTablePager.php
index 152d9fe..e9cc4aa 100644
--- a/includes/specials/pagers/NewsletterManageTablePager.php
+++ b/includes/specials/pagers/NewsletterManageTablePager.php
@@ -36,11 +36,12 @@
}
public function getQueryInfo() {
+ $userId = $this->getUser()->getId();
$this->newslettersOfPublisher = $this->mDb->selectFieldValues(
'nl_publishers',
'nlp_newsletter_id',
- array( 'nlp_publisher_id' => $this->getUser()->getId()
),
+ array( 'nlp_publisher_id' => $userId ),
__METHOD__
);
@@ -51,6 +52,7 @@
'nl_name',
'nlp_publisher_id',
),
+ 'conds' => array( 'nlp_publisher_id' => $userId ),
'join_conds' => array(
'nl_newsletters' => array( 'LEFT JOIN',
'nlp_newsletter_id = nl_id' ),
),
@@ -107,7 +109,7 @@
}
public function getDefaultSort() {
- return 'nl_id';
+ return 'nl_name';
}
public function isFieldSortable( $field ) {
--
To view, visit https://gerrit.wikimedia.org/r/249996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I892c00c855593bcb4ff79cf9259a79d8bc1f77c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Tinaj1234 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
