Dzahn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250052
Change subject: dnsrecursor: minimal quoting fixes
......................................................................
dnsrecursor: minimal quoting fixes
Change-Id: Iea416ccff3ec3439f2c367c4f3af756952eec3c1
---
M modules/dnsrecursor/manifests/init.pp
M modules/dnsrecursor/manifests/metrics.pp
M modules/dnsrecursor/manifests/monitor.pp
3 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/52/250052/1
diff --git a/modules/dnsrecursor/manifests/init.pp
b/modules/dnsrecursor/manifests/init.pp
index 56257fe..2306f30 100644
--- a/modules/dnsrecursor/manifests/init.pp
+++ b/modules/dnsrecursor/manifests/init.pp
@@ -9,14 +9,14 @@
$listen_addresses = [$::ipaddress],
$allow_from = [],
$ip_aliases = undef,
- $additional_forward_zones = "",
+ $additional_forward_zones = '',
$auth_zones = undef
) {
package { 'pdns-recursor':
ensure => 'present',
}
- $forward_zones = "wmnet=208.80.154.238;208.80.153.231;91.198.174.239,
10.in-addr.arpa=208.80.154.238;208.80.153.231;91.198.174.239"
+ $forward_zones = 'wmnet=208.80.154.238;208.80.153.231;91.198.174.239,
10.in-addr.arpa=208.80.154.238;208.80.153.231;91.198.174.239'
system::role { 'dnsrecursor':
ensure => 'absent',
diff --git a/modules/dnsrecursor/manifests/metrics.pp
b/modules/dnsrecursor/manifests/metrics.pp
index 71d645b..3ce693d 100644
--- a/modules/dnsrecursor/manifests/metrics.pp
+++ b/modules/dnsrecursor/manifests/metrics.pp
@@ -1,5 +1,5 @@
+# installs ganglia metrics reporting on pdns_recursor
class dnsrecursor::metrics {
- # install ganglia metrics reporting on pdns_recursor
file { '/usr/local/sbin/pdns_gmetric':
ensure => 'present',
owner => 'root',
diff --git a/modules/dnsrecursor/manifests/monitor.pp
b/modules/dnsrecursor/manifests/monitor.pp
index 37c8287..c1e1cb7 100644
--- a/modules/dnsrecursor/manifests/monitor.pp
+++ b/modules/dnsrecursor/manifests/monitor.pp
@@ -1,3 +1,4 @@
+# icinga monitoring for DNS recursors
define dnsrecursor::monitor() {
# Monitoring
monitoring::host { $title:
--
To view, visit https://gerrit.wikimedia.org/r/250052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea416ccff3ec3439f2c367c4f3af756952eec3c1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
