Kipcool has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250059
Change subject: suggest.js a bit of rewriting.
......................................................................
suggest.js a bit of rewriting.
Change-Id: I2b4951cbc5f5995a8350e57de3935859ea3d0c72
---
M resources/suggest.js
1 file changed, 15 insertions(+), 11 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData
refs/changes/59/250059/1
diff --git a/resources/suggest.js b/resources/suggest.js
index 55b7c65..165d6bd 100644
--- a/resources/suggest.js
+++ b/resources/suggest.js
@@ -89,8 +89,9 @@
* and buttons next, previous and clear
*/
function createSuggestStructure( element, suggestPrefix ) {
- var imgPath = mw.config.get( 'wgExtensionAssetsPath' ) +
'/WikiLexicalData/Images/',
- suggestStructure =
+ var imgPath, suggestStructure;
+ imgPath = mw.config.get( 'wgExtensionAssetsPath' ) +
'/WikiLexicalData/Images/';
+ suggestStructure =
'<div class="suggest-drop-down"><div id="' +
suggestPrefix + 'div" class="suggest-div">' +
'<table><tr>' +
'<td><input type="text" id="' +
suggestPrefix + 'text" autocomplete="off" class="suggest-text"/></td>' +
@@ -247,8 +248,9 @@
}
function updateSelectOptions(id, objectId, value) {
- var URL = 'index.php',
- location = "" + document.location;
+ var URL, location;
+ URL = 'index.php';
+ location = "" + document.location;
if (location.indexOf('index.php/') > 0) {
URL = '../' + URL;
@@ -284,13 +286,15 @@
});
$(".suggestion-row").click(function() {
- var suggestPrefix = stripSuffix(
$(this).closest('.suggest-div').attr('id'), 'div' ),
- suggestlink = '#' + suggestPrefix + 'link',
- idColumnsField =
$(suggestlink).attr('id-columns' ),
- displayLabelField =
$(suggestlink).attr('label-columns' ),
- displayLabelColumnIndices =
displayLabelField.split(", " ),
- labels = [],
- i, columnValue, idColumns, values, ids;
+ var suggestPrefix, suggestlink, idColumnsField,
displayLabelField, displayLabelColumnIndices, labels, i, columnValue,
idColumns, values, ids;
+
+ // suggestPrefix is something like
add-dm-1370660-def-transl-language-suggest-
+ suggestPrefix = stripSuffix(
$(this).closest('.suggest-div').attr('id'), 'div' );
+ suggestlink = '#' + suggestPrefix + 'link';
+ idColumnsField = $(suggestlink).attr('id-columns' );
+ displayLabelField = $(suggestlink).attr('label-columns'
);
+ displayLabelColumnIndices = displayLabelField.split(",
" );
+ labels = [];
for ( i = 0; i < displayLabelColumnIndices.length; i++)
{
columnValue =
this.getElementsByTagName('td')[displayLabelColumnIndices[i]].innerHTML;
--
To view, visit https://gerrit.wikimedia.org/r/250059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b4951cbc5f5995a8350e57de3935859ea3d0c72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLexicalData
Gerrit-Branch: master
Gerrit-Owner: Kipcool <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
