jenkins-bot has submitted this change and it was merged.
Change subject: Make status bar color consistent across activities.
......................................................................
Make status bar color consistent across activities.
Currently, our PageActivity uses a translucent status bar, which appears
slightly darker than the toolbar color (which is correct). However, in our
other activities (Login, Edit, etc), the status bar color looks much
lighter than the toolbar, and is inconsistent.
This patch provides a color for the status bar that is set via styles.
Note: only relevant for Lollipop+.
Change-Id: Ia5da4de8a42dbcf8810eb47f836471fc8dff73e9
---
M app/src/main/res/values/colors.xml
M app/src/main/res/values/styles.xml
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sniedzielski: Looks good to me, approved
Mholloway: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index 36fc774..6a49d16 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -27,6 +27,7 @@
<color name="search_text_hint">#808080</color>
<color name="lead_gradient_start">#b8000000</color>
<color name="main_toolbar_background">@color/actionbar_background</color>
+ <color name="status_bar_background">#1d1d1d</color>
<color name="link_light">#347bff</color>
<color name="button_light">#777</color>
diff --git a/app/src/main/res/values/styles.xml
b/app/src/main/res/values/styles.xml
index c41ec15..cde3ff9 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -6,6 +6,7 @@
<item name="longPreferenceStyle">@style/LongPreference</item>
<item name="intPreferenceStyle">@style/IntPreference</item>
<item name="android:windowBackground">@drawable/splash_bg</item>
+ <item name="android:statusBarColor"
tools:ignore="NewApi">@color/status_bar_background</item>
</style>
<style name="PageTheme" parent="AppTheme">
--
To view, visit https://gerrit.wikimedia.org/r/249769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5da4de8a42dbcf8810eb47f836471fc8dff73e9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
