Galorefitz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250061
Change subject: Remove mutliple wfEscapeShelArg() calls on $branch
......................................................................
Remove mutliple wfEscapeShelArg() calls on $branch
The variable $branch gets escaped twice, when the branch to be
pulled from is specified.
Bug: T115206
Change-Id: Ifba617fb384c6c3bb8ba1e1e8bd592ccc76e89ee
---
M Git2Pages.body.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Git2Pages
refs/changes/61/250061/1
diff --git a/Git2Pages.body.php b/Git2Pages.body.php
index b9e02b2..0e759a7 100644
--- a/Git2Pages.body.php
+++ b/Git2Pages.body.php
@@ -66,7 +66,7 @@
$options = self::extractOptions( $opts );
$url = $options['repository'];
if ( isset( $options['branch'] ) ) {
- $branch = wfEscapeShellArg( $options['branch'] );
+ $branch = $options['branch'];
} else {
$branch = 'master';
}
--
To view, visit https://gerrit.wikimedia.org/r/250061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifba617fb384c6c3bb8ba1e1e8bd592ccc76e89ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Git2Pages
Gerrit-Branch: master
Gerrit-Owner: Galorefitz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
