Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: changes default property graph to P373
......................................................................


changes default property graph to P373

Change-Id: I23e44684160584871f01c5b062c5d533020c11dd
---
M server.R
M src/output/server-developer.R
2 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved



diff --git a/server.R b/server.R
index de11d86..a0b771c 100644
--- a/server.R
+++ b/server.R
@@ -46,7 +46,7 @@
       if (!is.null(context$property)) {
         params_property <<- context$property
       } else {
-        params_property <<- "P1"
+        params_property <<- "P373"
       }
     })
 
diff --git a/src/output/server-developer.R b/src/output/server-developer.R
index 2d140c3..4278b95 100644
--- a/src/output/server-developer.R
+++ b/src/output/server-developer.R
@@ -8,18 +8,18 @@
   metric_range <- paste0("From ", first_sample, " To ", last_sample)
   box(title = "Definition", width = 6, status = "info", metric_desc, 
HTML("<br/>"), metric_range)
 })
-dt_getclaims_file <- data.table(wikidata_daily_getclaims_property_use)
-setkey(dt_getclaims_file, property)
-dt_getclaims_file <- dt_getclaims_file[which(dt_getclaims_file$date >= 
last_sample)]
-aggr_props <- 
aggregate(as.numeric(wikidata_daily_getclaims_property_use$count), 
by=list(wikidata_daily_getclaims_property_use$property), FUN = sum)
-aggr_props_ordered <- aggr_props[order(aggr_props$x, decreasing = TRUE),]
-dt_agg_props_ordered <- data.table(aggr_props_ordered)
-dt_agg_props_ordered <- setnames(dt_agg_props_ordered, c("property", "count"))
-setkey(dt_agg_props_ordered, property)
-aggr_props_join <- dt_agg_props_ordered[dt_getclaims_file]
-aggr_props_join <- aggr_props_join[,.SD,.SDcols=c(1:2,4)]
-aggr_props_join <- aggr_props_join[order(aggr_props_join$count, decreasing = 
TRUE)]
-output$wikidata_daily_getclaims_property_use_table <-DT::renderDataTable(
+output$wikidata_daily_getclaims_property_use_table <-DT::renderDataTable({
+  dt_getclaims_file <- data.table(wikidata_daily_getclaims_property_use)
+  setkey(dt_getclaims_file, property)
+  dt_getclaims_file <- dt_getclaims_file[which(dt_getclaims_file$date >= 
last_sample)]
+  aggr_props <- 
aggregate(as.numeric(wikidata_daily_getclaims_property_use$count), 
by=list(wikidata_daily_getclaims_property_use$property), FUN = sum)
+  aggr_props_ordered <- aggr_props[order(aggr_props$x, decreasing = TRUE),]
+  dt_agg_props_ordered <- data.table(aggr_props_ordered)
+  dt_agg_props_ordered <- setnames(dt_agg_props_ordered, c("property", 
"count"))
+  setkey(dt_agg_props_ordered, property)
+  aggr_props_join <- dt_agg_props_ordered[dt_getclaims_file]
+  aggr_props_join <- aggr_props_join[,.SD,.SDcols=c(1:2,4)]
+  aggr_props_join <- aggr_props_join[order(aggr_props_join$count, decreasing = 
TRUE)]
   datatable(aggr_props_join, class = "display compact", colnames = 
c("Property", "Agg. Count", paste0("Last Sample: ", last_sample), "Chart"),
             rownames = FALSE,
             options = list(
@@ -40,7 +40,7 @@
             ),
             caption = "Statistics for GetClaims Property Use") %>%
             formatCurrency(c("count","i.count"), currency = "", interval = 3, 
mark = ",")
-)
+})
 
 
 # http://wikiba.se/metrics#ParamPropertyGraph

-- 
To view, visit https://gerrit.wikimedia.org/r/250213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23e44684160584871f01c5b062c5d533020c11dd
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/analytics/dashboard
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
Gerrit-Reviewer: Christopher Johnson (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to