Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250218

Change subject: Update Jenkins tests
......................................................................

Update Jenkins tests

Add support for running jshint in npm.

Change-Id: I97ab0afa8edaba06821651b595a470b0771d354d
---
A .jshintignore
M Gruntfile.js
M package.json
3 files changed, 14 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless 
refs/changes/18/250218/1

diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 0000000..82eaa05
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1,2 @@
+node_modules/**
+vendor/**
diff --git a/Gruntfile.js b/Gruntfile.js
index 9c56558..a3db7eb 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,20 +1,27 @@
 /*jshint node:true */
 module.exports = function ( grunt ) {
-       grunt.loadNpmTasks( 'grunt-banana-checker' );
+       grunt.loadNpmTasks( 'grunt-contrib-jshint' );
        grunt.loadNpmTasks( 'grunt-jsonlint' );
+       grunt.loadNpmTasks( 'grunt-banana-checker' );
 
        grunt.initConfig( {
+               jshint: {
+                       all: [
+                               '**/*.js'
+                       ]
+               },
                banana: {
                        all: 'i18n/'
                },
                jsonlint: {
                        all: [
+                               '*.json',
                                '**/*.json',
                                '!node_modules/**'
                        ]
                }
        } );
 
-       grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+       grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
        grunt.registerTask( 'default', 'test' );
 };
diff --git a/package.json b/package.json
index 76e8a82..c3d4d83 100644
--- a/package.json
+++ b/package.json
@@ -6,7 +6,8 @@
   "devDependencies": {
     "grunt": "0.4.5",
     "grunt-cli": "0.1.13",
-    "grunt-banana-checker": "0.2.2",
-    "grunt-jsonlint": "1.0.4"
+    "grunt-contrib-jshint": "0.11.3",
+    "grunt-banana-checker": "0.4.0",
+    "grunt-jsonlint": "1.0.5"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/250218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97ab0afa8edaba06821651b595a470b0771d354d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to