jenkins-bot has submitted this change and it was merged.
Change subject: Eliminate still more system calls
......................................................................
Eliminate still more system calls
Change-Id: I1a3c0c0286b9a0051d1d60b08be13c9122f432a0
---
M multiversion/MWRealm.php
M tests/dbconfigTest.php
2 files changed, 13 insertions(+), 50 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/multiversion/MWRealm.php b/multiversion/MWRealm.php
index 1807be4..3f1b139 100644
--- a/multiversion/MWRealm.php
+++ b/multiversion/MWRealm.php
@@ -1,56 +1,15 @@
<?php
require_once( __DIR__ . '/MWWikiversions.php' );
-// Determine realm and datacenter we are on
-// $wmfRealm and $wmfDatacenter are used to vary configuration based on server
-// location. They should be provisioned by puppet in /etc/wikimedia-site and
-// /etc/wikimedia-realm.
-//
-// The possible values of $wmfRealm and $wmfDatacenter as of April 2015 are:
-// - labs + eqiad
-// - production + eqiad
-// - production + codfw
-global $wmfDatacenter, $wmfRealm;
-$wmfRealm = 'production';
-$wmfDatacenter = 'eqiad';
+global $wmfCluster, $wmfDatacenter, $wmfRealm;
-// Puppet provisions the realm in /etc/wikimedia-realm
-if( file_exists( '/etc/wikimedia-realm' ) ) {
- $wmfRealm = trim( file_get_contents( '/etc/wikimedia-realm' ) );
-}
-if( file_exists( '/etc/wikimedia-site' ) ) {
- $wmfDatacenter = trim( file_get_contents( '/etc/wikimedia-site' ) );
-}
-
-// Validate settings
-switch( $wmfRealm ) {
-case 'labs':
- # Anything different from eqiad is wrong in labs
- $wmfDatacenter = 'eqiad';
- break;
-case 'production':
- if ( ! in_array( $wmfDatacenter, array( 'eqiad', 'codfw' ) ) ) {
- $wmfDatacenter = 'eqiad';
- }
- break;
-default:
- # Assume something vaguely resembling a default
- $wmfRealm = 'production';
- $wmfDatacenter = 'eqiad';
- break;
-}
-
-/**
- * Function to list all valid realm/datacenter pairs, for testing purposes.
- *
- * @return array List of realm-datacenter pairs
- */
-function listAllRealmsAndDatacenters() {
- return array(
- array( 'production', 'eqiad' ),
- array( 'production', 'codfw' ),
- array( 'labs', 'eqiad' ),
- );
+$wmfCluster = trim( file_get_contents( '/etc/wikimedia-cluster' ) );
+if ( $wmfCluster === 'labs' ) {
+ $wmfRealm = 'labs';
+ $wmfDatacenter = 'eqiad';
+} else {
+ $wmfRealm = 'production';
+ $wmfDatacenter = $wmfCluster;
}
/**
diff --git a/tests/dbconfigTest.php b/tests/dbconfigTest.php
index f02ab7b..d733018 100644
--- a/tests/dbconfigTest.php
+++ b/tests/dbconfigTest.php
@@ -13,7 +13,11 @@
class dbconfigTests extends PHPUnit_Framework_TestCase {
public static function provideRealmDatacenter() {
- return listAllRealmsAndDatacenters();
+ return array(
+ array( 'production', 'eqiad' ),
+ array( 'production', 'codfw' ),
+ array( 'labs', 'eqiad' ),
+ );
}
function loadDbFile( $realm, $datacenter ) {
--
To view, visit https://gerrit.wikimedia.org/r/250173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a3c0c0286b9a0051d1d60b08be13c9122f432a0
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
