jenkins-bot has submitted this change and it was merged.
Change subject: Use page_touched in cache key instead of page_latest
......................................................................
Use page_touched in cache key instead of page_latest
Because the extracts depend upon template inclusion, to make sure
the extract is properly updated whenever the page's dependencies change,
use the page_touched timestamp instead of the latest revision id.
Since we're changing the cache key format, remove the 'mf' prefix from
back when it was still in MobileFrontend.
As a side-effect, this will also make action=purge invalidate the cache
since it updates page_touched.
Bug: T117322
Change-Id: Ib6f415c756c57caf6c83be495a4f229446e8b61e
---
M includes/ApiQueryExtracts.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/ApiQueryExtracts.php b/includes/ApiQueryExtracts.php
index 8e1d100..24dd0dd 100644
--- a/includes/ApiQueryExtracts.php
+++ b/includes/ApiQueryExtracts.php
@@ -138,7 +138,7 @@
}
private function cacheKey( WikiPage $page, $introOnly ) {
- return wfMemcKey( 'mf', 'extract', $page->getLatest(),
+ return wfMemcKey( 'textextracts', $page->getId(),
$page->getTouched(),
$page->getTitle()->getPageLanguage()->getPreferredVariant(),
$this->params['plaintext'], $introOnly
);
--
To view, visit https://gerrit.wikimedia.org/r/250293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6f415c756c57caf6c83be495a4f229446e8b61e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TextExtracts
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: MZMcBride <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Waldir <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
