Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250367
Change subject: Make makeKeyInternal() limit more conservative
......................................................................
Make makeKeyInternal() limit more conservative
This should avoid error log entries for long WAN cache keys
Change-Id: I401482d25dd5bf47052a3c6729c5f8bc9fd68770
---
M includes/libs/objectcache/MemcachedBagOStuff.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/67/250367/1
diff --git a/includes/libs/objectcache/MemcachedBagOStuff.php
b/includes/libs/objectcache/MemcachedBagOStuff.php
index ef6b3c7..162a531 100644
--- a/includes/libs/objectcache/MemcachedBagOStuff.php
+++ b/includes/libs/objectcache/MemcachedBagOStuff.php
@@ -103,8 +103,9 @@
public function makeKeyInternal( $keyspace, $args ) {
// Memcached keys have a maximum length of 255 characters. From
that,
// subtract the number of characters we need for the keyspace
and for
- // the separator character needed for each argument.
- $charsLeft = 255 - strlen( $keyspace ) - count( $args );
+ // the separator character needed for each argument. To handle
some
+ // custom prefixes used by thing like WANObjectCache, limit to
205.
+ $charsLeft = 205 - strlen( $keyspace ) - count( $args );
$args = array_map(
function ( $arg ) use ( &$charsLeft ) {
--
To view, visit https://gerrit.wikimedia.org/r/250367
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I401482d25dd5bf47052a3c6729c5f8bc9fd68770
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
