jenkins-bot has submitted this change and it was merged.
Change subject: Suggestions: Do not show the list heading for fallback
suggestions ("Featured")
......................................................................
Suggestions: Do not show the list heading for fallback suggestions ("Featured")
Bug: T115006
Bug: T116734
Change-Id: Icd1a8f09e22bfd6b0b2ecb032c3e3958c14dbd4f
---
M modules/dashboard/ext.cx.suggestionlist.js
M modules/dashboard/styles/ext.cx.suggestionlist.less
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/dashboard/ext.cx.suggestionlist.js
b/modules/dashboard/ext.cx.suggestionlist.js
index 401d1a4..fd00424 100644
--- a/modules/dashboard/ext.cx.suggestionlist.js
+++ b/modules/dashboard/ext.cx.suggestionlist.js
@@ -325,7 +325,13 @@
list.$list = $( '<div>' )
.attr( 'data-listid', listId )
.addClass( 'cx-suggestionlist ' + list.name );
- $listHeading = $( '<h2>' ).text( list.displayName );
+
+ if ( list.type === listTypes.TYPE_FEATURED ) {
+ // No need to show heading for misc fallback
suggestions shown at the end.
+ $listHeading = $( '<h2>' );
+ } else {
+ $listHeading = $( '<h2>' ).text(
list.displayName );
+ }
list.$list.append( $listHeading );
if ( addtoTop && this.$container.find(
'.cx-suggestionlist' ).length ) {
diff --git a/modules/dashboard/styles/ext.cx.suggestionlist.less
b/modules/dashboard/styles/ext.cx.suggestionlist.less
index 7842c97..59b9c00 100644
--- a/modules/dashboard/styles/ext.cx.suggestionlist.less
+++ b/modules/dashboard/styles/ext.cx.suggestionlist.less
@@ -118,3 +118,7 @@
border-radius: 1px;
font-size: small;
}
+
+.cx-suggestionlist-featured h2 {
+ margin-top: 20px;
+}
--
To view, visit https://gerrit.wikimedia.org/r/249903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd1a8f09e22bfd6b0b2ecb032c3e3958c14dbd4f
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
