Giuseppe Lavagetto has submitted this change and it was merged.

Change subject: Add tunable number of keepalive retries to IdleConnectionMonitor
......................................................................


Add tunable number of keepalive retries to IdleConnectionMonitor

Change-Id: Icdf309dcc501d1c6b2dee8f2df64b021f897f41a
---
M pybal/monitors/idleconnection.py
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Giuseppe Lavagetto: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pybal/monitors/idleconnection.py b/pybal/monitors/idleconnection.py
index 4e4b839..5ac7ea0 100644
--- a/pybal/monitors/idleconnection.py
+++ b/pybal/monitors/idleconnection.py
@@ -25,6 +25,7 @@
 
     TIMEOUT_CLEAN_RECONNECT = 3
     MAX_DELAY = 300
+    KEEPALIVE_RETRIES = 10
 
     __name__ = 'IdleConnection'
 
@@ -36,6 +37,8 @@
 
         self.toCleanReconnect = self._getConfigInt('timeout-clean-reconnect', 
self.TIMEOUT_CLEAN_RECONNECT)
         self.maxDelay = self._getConfigInt('max-delay', self.MAX_DELAY)
+        self.keepAliveRetries = self._getConfigInt('keepalive-retries',
+                                                   self.KEEPALIVE_RETRIES)
 
     def run(self):
         """Start the monitoring"""
@@ -97,7 +100,8 @@
             sock = self.transport.getHandle()
             sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
             sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPIDLE, 1)
-            sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPCNT, 2)
+            sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPCNT,
+                            self.keepAliveRetries)
             sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPINTVL, 1)
 
         # Set status to up

-- 
To view, visit https://gerrit.wikimedia.org/r/249983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icdf309dcc501d1c6b2dee8f2df64b021f897f41a
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/pybal
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Mark Bergsma <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to