Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250463
Change subject: Remove 'id' field and 'hist' link from Special:Newsletter
......................................................................
Remove 'id' field and 'hist' link from Special:Newsletter
ID is an internal detail that shouldn't be needed in this interface
and is already visible in the URL. 'hist' link is also unneeded
on a second thought.
Bug: T116353
Change-Id: Ifbdd7b8a39f448e663278344708ce54976c2482f
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialNewsletter.php
3 files changed, 1 insertion(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/63/250463/1
diff --git a/i18n/en.json b/i18n/en.json
index 0ee0bd3..1f811af 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -37,7 +37,6 @@
"newsletter-view-text": "This page allows you to view details about
specific newsletters. There is also an [[Special:Newsletters|overview of all
newsletters]] on this wiki.",
"newsletter-user-subscribed": "You are currently subscribed to this
newsletter.",
"newsletter-user-notsubscribed": "You are currently not subscribed to
this newsletter. You may subscribe to this newsletter by pressing the
\"{{int:newsletter-subscribe-button}}\" button if you wish to do so.",
- "newsletter-view-id": "Newsletter ID:",
"newsletter-view-name": "Newsletter name:",
"newsletter-view-mainpage": "Main page:",
"newsletter-view-description": "Description:",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 939b211..3385264 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -41,7 +41,6 @@
"newsletter-view-text": "Introductory message Special:Newsletter/<id>
if a newsletter by the specified id exists.",
"newsletter-user-subscribed": "Message shown on Special:Newsletter/<id>
if the current user is subscribed to the newsletter. Only shown for logged-in
users.",
"newsletter-user-notsubscribed": "Message shown on
Special:Newsletter/<id> if the current user is not subscribed to the
newsletter. Only shown for logged-in users. Has a reference to
{{msg-mw|newsletter-subscribe-button}}",
- "newsletter-view-id": "Label for newsletter id field. Shown on
Special:Newsletter/<id>",
"newsletter-view-name": "Label for newsletter name field. Shown on
Special:Newsletter/<id>",
"newsletter-view-mainpage": "Label for the newsletter's main page
field. Shown on Special:Newsletter/<id>\n{{Identical|Main page}}",
"newsletter-view-description": "Label for newsletter description field.
Shown on Special:Newsletter/<id>\n{{Identical|Description}}",
diff --git a/includes/specials/SpecialNewsletter.php
b/includes/specials/SpecialNewsletter.php
index dc50dc5..c121a3d 100644
--- a/includes/specials/SpecialNewsletter.php
+++ b/includes/specials/SpecialNewsletter.php
@@ -105,11 +105,6 @@
$publishers = UserArray::newFromIDs(
$this->newsletter->getPublishers() );
$mainTitle = Title::newFromID( $this->newsletter->getPageId() );
$fields = array(
- 'id' => array(
- 'type' => 'info',
- 'label-message' => 'newsletter-view-id',
- 'default' => (string)$this->newsletter->getId(),
- ),
'name' => array(
'type' => 'info',
'label-message' => 'newsletter-view-name',
@@ -118,11 +113,7 @@
'mainpage' => array(
'type' => 'info',
'label-message' => 'newsletter-view-mainpage',
- 'default' => Linker::link( $mainTitle,
htmlspecialchars( $mainTitle->getPrefixedText() ) )
- . ' '
- . $this->msg( 'parentheses'
)->rawParams(
- Linker::link( $mainTitle,
'hist', array(), array( 'action' => 'history' ) )
- )->escaped(),
+ 'default' => Linker::link( $mainTitle,
htmlspecialchars( $mainTitle->getPrefixedText() ) ),
'raw' => true,
),
'description' => array(
--
To view, visit https://gerrit.wikimedia.org/r/250463
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbdd7b8a39f448e663278344708ce54976c2482f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
