jenkins-bot has submitted this change and it was merged.
Change subject: Replace some trivial assertEquals with assertNull and such
......................................................................
Replace some trivial assertEquals with assertNull and such
Change-Id: I13480983a3eae823fc27e287286b06189363192a
---
M client/tests/phpunit/includes/Hooks/ParserOutputUpdateHookHandlersTest.php
M client/tests/phpunit/includes/ParserOutputDataUpdaterTest.php
M lib/tests/phpunit/MockRepositoryTest.php
M repo/tests/phpunit/includes/store/sql/WikiPageEntityMetaDataLookupTest.php
4 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/client/tests/phpunit/includes/Hooks/ParserOutputUpdateHookHandlersTest.php
b/client/tests/phpunit/includes/Hooks/ParserOutputUpdateHookHandlersTest.php
index 3dca763..1ddee1e 100644
--- a/client/tests/phpunit/includes/Hooks/ParserOutputUpdateHookHandlersTest.php
+++ b/client/tests/phpunit/includes/Hooks/ParserOutputUpdateHookHandlersTest.php
@@ -343,7 +343,7 @@
$handler->doContentAlterParserOutput( $title, $parserOutput );
- $this->assertSame( false, $parserOutput->getProperty(
'wikibase_item' ) );
+ $this->assertFalse( $parserOutput->getProperty( 'wikibase_item'
) );
$this->assertEmpty( $parserOutput->getLanguageLinks() );
$this->assertEmpty( $parserOutput->getExtensionData(
'wikibase-otherprojects-sidebar' ) );
diff --git a/client/tests/phpunit/includes/ParserOutputDataUpdaterTest.php
b/client/tests/phpunit/includes/ParserOutputDataUpdaterTest.php
index f2d93a5..195c9a2 100644
--- a/client/tests/phpunit/includes/ParserOutputDataUpdaterTest.php
+++ b/client/tests/phpunit/includes/ParserOutputDataUpdaterTest.php
@@ -150,7 +150,7 @@
$parserOutputDataUpdater->updateItemIdProperty( $title,
$parserOutput );
$property = $parserOutput->getProperty( 'wikibase_item' );
- $this->assertEquals( false, $property );
+ $this->assertFalse( $property );
}
/**
diff --git a/lib/tests/phpunit/MockRepositoryTest.php
b/lib/tests/phpunit/MockRepositoryTest.php
index ce5b1b5..dec6cb1 100644
--- a/lib/tests/phpunit/MockRepositoryTest.php
+++ b/lib/tests/phpunit/MockRepositoryTest.php
@@ -149,20 +149,20 @@
$itemId = $item->getId();
$this->assertEquals( $itemId, $this->repo->getItemIdForLink(
'enwiki', 'Foo' ) );
- $this->assertEquals( null, $this->repo->getItemIdForLink(
'xywiki', 'Foo' ) );
+ $this->assertNull( $this->repo->getItemIdForLink( 'xywiki',
'Foo' ) );
// test lookup after item modification
$item->getSiteLinkList()->setNewSiteLink( 'enwiki', 'Bar' );
$this->repo->putEntity( $item );
- $this->assertEquals( null, $this->repo->getItemIdForLink(
'enwiki', 'Foo' ) );
+ $this->assertNull( $this->repo->getItemIdForLink( 'enwiki',
'Foo' ) );
$this->assertEquals( $itemId, $this->repo->getItemIdForLink(
'enwiki', 'Bar' ) );
// test lookup after item deletion
$this->repo->removeEntity( $itemId );
- $this->assertEquals( null, $this->repo->getItemIdForLink(
'enwiki', 'Foo' ) );
- $this->assertEquals( null, $this->repo->getItemIdForLink(
'enwiki', 'Bar' ) );
+ $this->assertNull( $this->repo->getItemIdForLink( 'enwiki',
'Foo' ) );
+ $this->assertNull( $this->repo->getItemIdForLink( 'enwiki',
'Bar' ) );
}
public function provideGetLinks() {
diff --git
a/repo/tests/phpunit/includes/store/sql/WikiPageEntityMetaDataLookupTest.php
b/repo/tests/phpunit/includes/store/sql/WikiPageEntityMetaDataLookupTest.php
index d171438..16f6b7b 100644
--- a/repo/tests/phpunit/includes/store/sql/WikiPageEntityMetaDataLookupTest.php
+++ b/repo/tests/phpunit/includes/store/sql/WikiPageEntityMetaDataLookupTest.php
@@ -88,7 +88,7 @@
$entityRevision ->getRevisionId() * 2 //
Doesn't exist
);
- $this->assertSame( false, $result );
+ $this->assertFalse( $result );
}
public function testLoadRevisionInformationById_notFound() {
@@ -98,7 +98,7 @@
823487354
);
- $this->assertSame( false, $result );
+ $this->assertFalse( $result );
}
public function testLoadRevisionInformation() {
--
To view, visit https://gerrit.wikimedia.org/r/250443
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13480983a3eae823fc27e287286b06189363192a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
