Isarra has submitted this change and it was merged.
Change subject: Change searchInput placeholder (i18n message example)
......................................................................
Change searchInput placeholder (i18n message example)
Also fix a $this->msg reference I missed before.
Change-Id: I2082cec190fbbb923cde9bed47cfbf5fd4225613
---
M TimelessTemplate.php
M i18n/en.json
M i18n/qqq.json
3 files changed, 11 insertions(+), 4 deletions(-)
Approvals:
Isarra: Verified; Looks good to me, approved
diff --git a/TimelessTemplate.php b/TimelessTemplate.php
index 5ecae6c..9d226a0 100644
--- a/TimelessTemplate.php
+++ b/TimelessTemplate.php
@@ -203,12 +203,17 @@
?>
<div class="mw-portlet" id="p-search">
<h3<?php $this->html( 'userlangattributes' ) ?>>
- <label for="searchInput"><?php $this->msg(
'search' ) ?></label>
+ <label for="searchInput"><?php echo
$this->getMsg( 'search' )->parse() ?></label>
</h3>
<form action="<?php $this->text( 'wgScript' ) ?>"
id="searchform">
<div id="simpleSearch">
<div id="searchInput-container">
- <?php echo $this->makeSearchInput(
array( 'id' => 'searchInput' ) ); ?>
+ <?php
+ echo $this->makeSearchInput( array(
+ 'id' => 'searchInput',
+ 'placeholder' => $this->getMsg(
'timeless-search-placeholder' )->escaped(),
+ ) );
+ ?>
</div>
<?php
echo Html::hidden( 'title', $this->get(
'searchtitle' ) );
diff --git a/i18n/en.json b/i18n/en.json
index a6ecf87..a08744c 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -3,5 +3,6 @@
"authors": [ "Isarra" ]
},
"skinname-timeless": "Timeless",
- "timeless-desc": "A timeless skin designed after the Winter prototype
by Brandon Harris."
+ "timeless-desc": "A timeless skin designed after the Winter prototype
by Brandon Harris.",
+ "timeless-search-placeholder": "Search approximately {{NUMBEROFPAGES}}
pages"
}
diff --git a/i18n/qqq.json b/i18n/qqq.json
index f66c97e..250a8ad 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -3,5 +3,6 @@
"authors": [ "..." ]
},
"skinname-timeless": "{{optional}}",
- "timeless-desc":
"{{desc|what=skin|name=Timeless|url=https://www.mediawiki.org/wiki/Skin:Timeless}}";
+ "timeless-desc":
"{{desc|what=skin|name=Timeless|url=https://www.mediawiki.org/wiki/Skin:Timeless}}";,
+ "timeless-search-placeholder": "Main search input placeholder text"
}
--
To view, visit https://gerrit.wikimedia.org/r/250364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2082cec190fbbb923cde9bed47cfbf5fd4225613
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Isarra <[email protected]>
Gerrit-Reviewer: Isarra <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
