Gilles has submitted this change and it was merged.

Change subject: Docker Markdown doesn't support HTML
......................................................................


Docker Markdown doesn't support HTML

Lets change the pre tags to Markdown so that the readme looks good
at the Docker hub.

Change-Id: Idb8445a6737f0b23cf18c4dea03c780eb5c1ce34
---
M README.md
1 file changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Gilles: Verified; Looks good to me, approved



diff --git a/README.md b/README.md
index 6f26df6..7e091c0 100644
--- a/README.md
+++ b/README.md
@@ -8,37 +8,37 @@
 
 ## Build the container
 If you make changes and want to test them locally, you can build the container 
like this:
-<pre>
+```
 docker build -t wikimedia/visualmetrics .
-</pre>
+```
 
 ## Download the container
-<pre>
+```
 docker pull wikimedia/visualmetrics
-</pre>
+```
 
 ## Help
 You an check what you can do with visualmetrics by using help:
-<pre>
+```
 docker run wikimedia/visualmetrics python visualmetrics.py --help
-</pre>
+```
 
 ## Run
 Fetch metrics, converting a video located in the current directory, storing 
images to an images folder:
-<pre>
+```
 docker run -v "$(pwd)":/tmp wikimedia/visualmetrics python visualmetrics.py 
--video /tmp/facebook-bad-network.mov --orange -k --dir /tmp/images --force
-</pre>
+```
 
 ## Record a video
 To record a video you can follow the same procedure as WebPageTest. First go 
to a blank page by adding the URL **data:text/html;charset=utf-8,** then set 
the background color to orange. That will help the visual metrics to know when 
we start doing the test.
 
-<pre>
+```
 document.body.style.background = "#DE640D"
-</pre>
+```
 
 When you have started the video recording of the browser, change the 
background and the URL.
-<pre>
+```
 document.body.style.background = "#FFFFFF"; 
document.location.href="https://en.wikipedia.org/wiki/Facebook";;
-</pre>
+```
 
 For more information checkout https://github.com/WPO-Foundation/visualmetrics

-- 
To view, visit https://gerrit.wikimedia.org/r/249875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb8445a6737f0b23cf18c4dea03c780eb5c1ce34
Gerrit-PatchSet: 2
Gerrit-Project: performance/visualmetrics-docker
Gerrit-Branch: master
Gerrit-Owner: Phedenskog <phedens...@wikimedia.org>
Gerrit-Reviewer: Gilles <gdu...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to