jenkins-bot has submitted this change and it was merged.
Change subject: Do not hide if the descendants of the trigger is clicked.
......................................................................
Do not hide if the descendants of the trigger is clicked.
Bug: T116637
Change-Id: Ibc182a67601efded27c49ba818b0e3cbf5a3231b
---
M resources/js/ext.translate.groupselector.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nikerabbit: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.groupselector.js
b/resources/js/ext.translate.groupselector.js
index f755b48..d53bead 100644
--- a/resources/js/ext.translate.groupselector.js
+++ b/resources/js/ext.translate.groupselector.js
@@ -135,7 +135,7 @@
*/
hide: function ( e ) {
// Do not hide if the trigger is clicked
- if ( e && this.$trigger.is( e.target ) ) {
+ if ( e && ( this.$trigger.is( e.target ) ||
this.$trigger.has( e.target ).length ) ) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/248934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc182a67601efded27c49ba818b0e3cbf5a3231b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Phoenix303 <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits